feat(http): migrate HTTP conventions to Weaver schema v2 - Closes #3809 #3827
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| change_type: enhancement | ||
| component: http | ||
| note: Migrate HTTP semantic conventions to Weaver v2 schema | ||
| issues: [3809] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,144 +1,151 @@ | ||
| file_format: definition/2 | ||
|
|
||
|
|
||
| attributes: | ||
| - key: http.method | ||
| type: string | ||
| brief: 'Deprecated, use `http.request.method` instead.' | ||
| stability: development | ||
| deprecated: | ||
| reason: renamed | ||
| renamed_to: http.request.method | ||
| note: "Replaced by `http.request.method`." | ||
|
Contributor
There was a problem hiding this comment. Strange that these are now required, have logged open-telemetry/weaver#1556 as this will be adding alot of un-necessary boilerplate.
Contributor
Author
There was a problem hiding this comment. Hey @thompson-tomo, Thanks for the help! Ihave fetched and applied your commit (a0c77f4) to my branch as requested. I see the CI is still failing on link checks as expected due to the Weaver definition/2 issue i understand that this PR is now blocked until your PR #3836 is merged to fix the underlying tool issue
Contributor
There was a problem hiding this comment. Correct this is now blocked until we have a solution for the attributes in the wrong namespace issue which my pr solves. I have managed to descope my pr to avoid namespaces which had meaningful text which should make it easier to review. |
||
| examples: ["GET", "POST", "HEAD"] | ||
| - key: http.status_code | ||
| type: int | ||
| brief: 'Deprecated, use `http.response.status_code` instead.' | ||
| stability: development | ||
| deprecated: | ||
| reason: renamed | ||
| renamed_to: http.response.status_code | ||
| note: "Replaced by `http.response.status_code`." | ||
| examples: [200] | ||
| - key: http.scheme | ||
| type: string | ||
| brief: 'Deprecated, use `url.scheme` instead.' | ||
| stability: development | ||
| deprecated: | ||
| reason: renamed | ||
| renamed_to: url.scheme | ||
| note: "Replaced by `url.scheme`." | ||
| examples: ['http', 'https'] | ||
| - key: http.url | ||
| type: string | ||
| brief: 'Deprecated, use `url.full` instead.' | ||
| stability: development | ||
| deprecated: | ||
| reason: renamed | ||
| renamed_to: url.full | ||
| note: "Replaced by `url.full`." | ||
| examples: ['https://www.foo.bar/search?q=OpenTelemetry#SemConv'] | ||
| - key: http.target | ||
| type: string | ||
| brief: 'Deprecated, use `url.path` and `url.query` instead.' | ||
| stability: development | ||
| deprecated: | ||
| reason: obsoleted | ||
| note: Split to `url.path` and `url.query`. | ||
| examples: ['/search?q=OpenTelemetry#SemConv'] | ||
| - key: http.request_content_length | ||
| type: int | ||
| brief: 'Deprecated, use `http.request.header.content-length` instead.' | ||
| stability: development | ||
| deprecated: | ||
| reason: uncategorized | ||
| note: Replaced by `http.request.header.content-length`. | ||
| examples: 3495 | ||
| - key: http.response_content_length | ||
| type: int | ||
| brief: 'Deprecated, use `http.response.header.content-length` instead.' | ||
| stability: development | ||
| deprecated: | ||
| reason: uncategorized | ||
| note: Replaced by `http.response.header.content-length`. | ||
| examples: 3495 | ||
| - key: http.client_ip | ||
| type: string | ||
| stability: development | ||
| deprecated: | ||
| reason: renamed | ||
| renamed_to: client.address | ||
| note: "Replaced by `client.address`." | ||
| brief: "Deprecated, use `client.address` instead." | ||
| examples: '83.164.160.102' | ||
| - key: http.host | ||
| type: string | ||
| stability: development | ||
| deprecated: | ||
| reason: uncategorized | ||
| note: > | ||
| Replaced by one of `server.address`, `client.address` or `http.request.header.host`, depending on the usage. | ||
| brief: "Deprecated, use one of `server.address`, `client.address` or `http.request.header.host` instead, depending on the usage." | ||
| examples: ['www.example.org'] | ||
| - key: http.request_content_length_uncompressed | ||
| stability: development | ||
| deprecated: | ||
| reason: renamed | ||
| renamed_to: http.request.body.size | ||
| note: "Replaced by `http.request.body.size`." | ||
| type: int | ||
| brief: "Deprecated, use `http.request.body.size` instead." | ||
| examples: 5493 | ||
| - key: http.response_content_length_uncompressed | ||
| stability: development | ||
| deprecated: | ||
| reason: renamed | ||
| renamed_to: http.response.body.size | ||
| note: "Replaced by `http.response.body.size`." | ||
| type: int | ||
| brief: "Deprecated, use `http.response.body.size` instead." | ||
| examples: 5493 | ||
| - key: http.server_name | ||
| type: string | ||
| stability: development | ||
| deprecated: | ||
| reason: renamed | ||
| renamed_to: server.address | ||
| note: "Replaced by `server.address`." | ||
| brief: "Deprecated, use `server.address` instead." | ||
| examples: ['example.com'] | ||
| - key: http.flavor | ||
| type: | ||
| members: | ||
| - id: http_1_0 | ||
| value: '1.0' | ||
| brief: 'HTTP/1.0' | ||
| stability: development | ||
| - id: http_1_1 | ||
| value: '1.1' | ||
| brief: 'HTTP/1.1' | ||
| stability: development | ||
| - id: http_2_0 | ||
| value: '2.0' | ||
| brief: 'HTTP/2' | ||
| stability: development | ||
| - id: http_3_0 | ||
| value: '3.0' | ||
| brief: 'HTTP/3' | ||
| stability: development | ||
| - id: spdy | ||
| value: 'SPDY' | ||
| brief: 'SPDY protocol.' | ||
| stability: development | ||
| - id: quic | ||
| value: 'QUIC' | ||
| brief: 'QUIC protocol.' | ||
| stability: development | ||
| brief: 'Deprecated, use `network.protocol.name` and `network.protocol.version` instead.' | ||
| deprecated: | ||
| reason: uncategorized | ||
| note: "Split into `network.protocol.name` and `network.protocol.version`" | ||
| stability: development | ||
| - key: http.user_agent | ||
| type: string | ||
| brief: 'Deprecated, use `user_agent.original` instead.' | ||
| examples: ['CERN-LineMode/2.15 libwww/2.17b3', | ||
| 'Mozilla/5.0 (iPhone; CPU iPhone OS 14_7_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/14.1.2 Mobile/15E148 Safari/604.1'] | ||
| deprecated: | ||
| reason: renamed | ||
| renamed_to: user_agent.original | ||
| note: "Replaced by `user_agent.original`." | ||
| stability: development | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.