[chore] [editoral] switch to md frontmatter#2971
Conversation
|
Build issue due to current toc generator having known issues with front matter syntax & isn't mantained. Will need to be addressed by switching to https://www.npmjs.com/package/doctoc |
f200c55 to
b48a142
Compare
1f2059f to
2c6b739
Compare
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
|
@open-telemetry/specs-semconv-maintainers can we re-open as we await @chalin or someone else to review. Key thing is this is needed to improve website publishing process & is a pre-requiste for introducing specs.opentelemetry.io. |
|
@thompson-tomo - can you ensure that this is up to date, and I'll start final tests on the otel.io side to ensure that this can land smoothly. |
chalin
left a comment
There was a problem hiding this comment.
@thompson-tomo - FYI, I'll be making some progress on this this month. See inline comments for a tweak and question.
Btw, what's in place to ensure that the Hugo fm title and page title match. I thought that we had a checker in place, but I'm not seeing that in the scope of this PR.
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
| title: Attribute requirement levels | ||
| linkTitle: Attribute requirement levels |
There was a problem hiding this comment.
As clarified via #3843 (comment), there should be no linkTitle entry when it matches the title. This applies to many changes in this commit.
There was a problem hiding this comment.
My mistake. Have reverted that.
|
I have just updated the branch and completed an audit so it is up to date. Note #3671 will update the files under the registry directory as they are 100% auto generated. So currently there is nothing in place to keep them in sync. I did previously have a custom textlint rule in-place. Note I already have a pr open to perform the textlint corrections for casing etc #3747 & a draft pr to enforce textlint in ci. #3578. |
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
How did you "complete the audit"? Do you have a script? Is it a part of this repo already?
I'm ok landing this earlier and brining in the sync check later.
|
I manually went through checking that each page under docs except the registry section. had both a title & linkTitle. The titles were previously all set via a script which I doubt I have anymore. Link titles were mostly already there. |
joaopgrassi
left a comment
There was a problem hiding this comment.
Before even reviewing this, I'd like us to have a mechanism to:
- Check that each page has the frontmatter
- That it matches the header
Without it this will become stale, so I think it needs to be done together and not as a follow up.
|
@joaopgrassi based on your request for linting of content to ensure that frontmatter is present & matches h1. Can you review #3578 which adds textlint (used in otel.io & spec) to do the linting and then in this pr we would configure the additional linting rules/plugins. |
|
@chalin i have committed the textlint rules to https://github.com/wemicroit/textlint-rules and hope to have 1 if not both published within the next few days. By publishing it we can use the same rule in the other spec repos. |
This partially reverts commit 96609e4.
Pull request dashboard statusStatus last refreshed: 2026-07-25 20:56:27 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Progresses #1821
Changes
This switches the manual docs to use github front matter syntax rather than embedding the front matter in comments. Currently these comments need to be processed before they can be used on the website version.
This change will also help in reviews as the link title etc are front and center.
The docs now have an explicit title front matter property which should match h1.
Question's:
Do we need to keepHas been removed based on feedback# Hugo front matter used to generate the website version of this page? Or can it be removed?Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]