ci: remediate zizmor findings#538
Draft
opentelemetrybot wants to merge 4 commits into
Draft
Conversation
14 tasks
There was a problem hiding this comment.
Pull request overview
This PR tightens GitHub Actions security posture and remediates zizmor findings by preventing persisted checkout credentials and reducing expression expansion in shell command arguments, while keeping code scanning/reporting behavior intact.
Changes:
- Disable persisted
actions/checkoutcredentials across multiple workflows (persist-credentials: false). - Refactor a Gradle invocation to pass dynamic values via environment variables instead of direct workflow expression interpolation.
- Add
gh auth setup-gitwhere needed to support authenticated git operations (partially), aligning with zizmor remediation guidance.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/reusable-lint-check.yml | Disables persisted checkout credentials for lint workflow. |
| .github/workflows/release.yml | Disables persisted checkout credentials in release workflows; needs explicit git auth setup for later pushes. |
| .github/workflows/prepare-release-branch.yml | Disables persisted checkout credentials; one job that later pushes now needs explicit git auth setup. |
| .github/workflows/issue-management-feedback-label.yml | Disables persisted checkout credentials for issue label automation workflow. |
| .github/workflows/gradle-wrapper-validation.yml | Disables persisted checkout credentials for wrapper validation workflow. |
| .github/workflows/fossa.yml | Disables persisted checkout credentials for FOSSA scan workflow. |
| .github/workflows/codeql.yml | Disables persisted checkout credentials for CodeQL workflow. |
| .github/workflows/build-common.yml | Disables persisted checkout credentials; refactors Gradle args to use env vars to avoid template-injection concerns. |
| .github/workflows/auto-update-semconv.yml | Disables persisted checkout credentials; adds gh auth setup-git for authenticated pushes when creating PRs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
opentelemetrybot
marked this pull request as ready for review
July 21, 2026 03:22
trask
marked this pull request as draft
July 21, 2026 04:37
Member
|
cc @trask to review first |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked in open-telemetry/sig-security#293.
Resolves existing findings from the OpenTelemetry shared workflow.
The workflow:
regularpersona on pull requests, pushes tomain,release/*, and a randomized weekly schedule;Zizmor remediation
This change also resolves findings from these zizmor rules:
artipackedtemplate-injectionAfter merge
open-telemetry/admincontinues to require zizmor code scanning for this repository.zizmorcode-scanning result.If enforcement unexpectedly blocks a valid change, restore
require_zizmor = falseinopen-telemetry/adminwhile leaving scanning enabled.