chore(ci): track df_engine .text size and per-crate bloat on merges to main#3586
Open
mateenali66 wants to merge 1 commit into
Open
chore(ci): track df_engine .text size and per-crate bloat on merges to main#3586mateenali66 wants to merge 1 commit into
mateenali66 wants to merge 1 commit into
Conversation
…o main Adds a push-to-main trigger and a native cargo-bloat job (amd64 + arm64) to the binary size workflow. The docker job keeps measuring the shipped stripped size; the new job builds with symbols and records the .text section size plus the top 10 crate contributions per arch, all merged into the same consolidated benchmark json published to the benchmarks page. Fixes open-telemetry#2673 Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
github-actions
Bot
added
ci-repo
Pull request dashboard statusStatus last refreshed: 2026-07-26 19:03:41 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3586 +/- ##
==========================================
- Coverage 86.91% 86.91% -0.01%
==========================================
Files 783 783
Lines 321311 321311
==========================================
- Hits 279283 279266 -17
- Misses 41504 41521 +17
Partials 524 524
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
adds the missing pieces from #2673 to the binary size workflow: a push-to-main trigger so metrics land per merge (was daily cron only), and a native cargo-bloat job on amd64 + arm64 that builds with symbols and records the
.textsection size plus the top 10 crate contributions per arch (tracked separately per arch, as preferred in the issue discussion). the docker job is untouched, it keeps measuring the shipped stripped size.also fixed the summary merge:
jq -s 'map(.[0])'only kept the first entry of each report file, which would have dropped the new multi-entry bloat reports. switched toadd, and the results table now prints every metric.one thing to watch: the 110% alert threshold now also applies to the per-crate series. crate attribution can shift when inlining changes, so if that alerts too often the crate series could move to a separate benchmark step with a higher threshold.
What issue does this PR close?
df_enginebinary size in CI #2673How are these changes tested?
ran the full workflow end to end via workflow_dispatch on my fork (both arches, docker + bloat jobs + summary): https://github.com/mateenali66/otel-arrow/actions/runs/30155340424. cargo-bloat's json schema (
file-size,text-section-size,crates[]) and the jq transform were also verified locally against captured output.Are there any user-facing changes?
no, CI only.
Changelog
.chloggen/*.yamlentrychore(indicated in title)