[query-engine] Add empty structure for columnar engine#3554
Open
CodeBlanch wants to merge 3 commits into
Open
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-26 03:48:12 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new (currently empty) Rust crate to the experimental query engine workspace to serve as the initial project skeleton for a future general-purpose columnar engine implementation.
Changes:
- Introduced new workspace member
engine-columnar. - Added a new crate (
data_engine_columnar) with workspace-inherited package metadata. - Added a minimal
src/lib.rscontaining only license headers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/experimental/query_engine/engine-columnar/src/lib.rs | Adds initial crate source file with required license headers. |
| rust/experimental/query_engine/engine-columnar/Cargo.toml | Defines the new crate’s package metadata, inheriting settings from the workspace. |
| rust/experimental/query_engine/Cargo.toml | Registers engine-columnar as a workspace member. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
@CodeBlanch Would you add a README.md explaining what scope of work will be implemented in this new location? |
Member
Author
|
@jmacd Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Details
This will be filled in over subsequent PRs.