refactor: Use std Io writer for exporters - #44
Merged
inge4pres merged 1 commit intoJul 24, 2026
Conversation
|
|
jaronoff97
approved these changes
Jul 22, 2026
Member
|
@aland-omed thanks for sending this PR! It's beautiful ❤️ I'll fix it! |
Signed-off-by: Aland <158173939+aland-omed@users.noreply.github.com>
inge4pres
force-pushed
the
refactor/writer-exporters-30
branch
from
July 22, 2026 15:53
ac0dac1 to
9e63811
Compare
Member
It was easier than I though, I simply rebased on main 😅 |
agagniere
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #30.
Replace the log and trace
GenericWriterExportercompile-time generic with a concrete exporter that accepts*std.Io.Writer. This removes runtime field inspection for concrete writer layouts while preserving the existing stdout and in-memory exporter names.The C wrappers, tests, and examples now retain their concrete writers for the exporter lifetime and pass the standard writer interface explicitly.
Validation:
zig buildzig build test(289 tests passed)zig build exampleszig fmt --checkon all changed Zig filesgit diff --check