fix(resource): percent-decode attribute values#3586
Open
9999years wants to merge 1 commit into
Open
Conversation
9999years
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3586 +/- ##
=======================================
+ Coverage 83.0% 83.2% +0.1%
=======================================
Files 130 130
Lines 27993 28234 +241
=======================================
+ Hits 23250 23493 +243
+ Misses 4743 4741 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9999years
marked this pull request as ready for review
July 7, 2026 17:43
9999years
added a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Jul 7, 2026
This integrates the Mercury `opentelemetry-rust` fork with fixes from a couple PRs: See: - open-telemetry/opentelemetry-rust#3586 - open-telemetry/opentelemetry-rust#3587 Follow-up to Arian's review: #18 (review)
9999years
added a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Jul 7, 2026
This integrates the Mercury `opentelemetry-rust` fork with fixes from a couple PRs: See: - open-telemetry/opentelemetry-rust#3586 - open-telemetry/opentelemetry-rust#3587 Follow-up to Arian's review: #18 (review)
9999years
added a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Jul 8, 2026
This integrates the Mercury `opentelemetry-rust` fork with fixes from a couple PRs: See: - open-telemetry/opentelemetry-rust#3586 - open-telemetry/opentelemetry-rust#3587 Follow-up to Arian's review: #18 (review)
hdgarrood
pushed a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Jul 10, 2026
This integrates the Mercury `opentelemetry-rust` fork with fixes from a couple PRs: See: - open-telemetry/opentelemetry-rust#3586 - open-telemetry/opentelemetry-rust#3587 Follow-up to Arian's review: #18 (review)
hdgarrood
pushed a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Jul 11, 2026
This integrates the Mercury `opentelemetry-rust` fork with fixes from a couple PRs: See: - open-telemetry/opentelemetry-rust#3586 - open-telemetry/opentelemetry-rust#3587 Follow-up to Arian's review: #18 (review)
hdgarrood
pushed a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Jul 11, 2026
This integrates the Mercury `opentelemetry-rust` fork with fixes from a couple PRs: See: - open-telemetry/opentelemetry-rust#3586 - open-telemetry/opentelemetry-rust#3587 Follow-up to Arian's review: #18 (review)
hdgarrood
pushed a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Jul 15, 2026
This integrates the Mercury `opentelemetry-rust` fork with fixes from a couple PRs: See: - open-telemetry/opentelemetry-rust#3586 - open-telemetry/opentelemetry-rust#3587 Follow-up to Arian's review: #18 (review)
hdgarrood
pushed a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Jul 15, 2026
This integrates the Mercury `opentelemetry-rust` fork with fixes from a couple PRs: See: - open-telemetry/opentelemetry-rust#3586 - open-telemetry/opentelemetry-rust#3587 Follow-up to Arian's review: #18 (review)
hdgarrood
pushed a commit
to MercuryTechnologies/buck2
that referenced
this pull request
Jul 15, 2026
This integrates the Mercury `opentelemetry-rust` fork with fixes from a couple PRs: See: - open-telemetry/opentelemetry-rust#3586 - open-telemetry/opentelemetry-rust#3587 Follow-up to Arian's review: #18 (review)
lalitb
reviewed
Jul 21, 2026
| @@ -50,9 +51,13 @@ fn construct_otel_resources(s: String) -> Resource { | |||
| None => return None, | |||
| }; | |||
| let key = parts.0.trim(); | |||
Member
There was a problem hiding this comment.
I believe we should also percent-decode keys. As per specs:
The OTEL_RESOURCE_ATTRIBUTES environment variable will contain of a list of key value pairs, represented as key1=value1,key2=value2. All attribute values MUST be considered strings. The , and = characters in keys and values MUST be percent encoded. Other characters MAY be [percent-encoded](https://datatracker.ietf.org/doc/html/rfc3986#section-2.1), e.g. values outside the ANSI characters set.
lalitb
reviewed
Jul 21, 2026
| // (e.g. `%20`) in the value is preserved. Per the Resource SDK spec | ||
| // the value MUST be percent-decoded; keys are baggage tokens and are | ||
| // not encoded. | ||
| let value = percent_decode_str(parts.1.trim()).decode_utf8_lossy(); |
Member
There was a problem hiding this comment.
decode_utf8_lossy() accepts invalid encoded UTF-8 by inserting replacement characters. The Resource SDK spec says decoding failures should discard the entire env var and report an error. The existing baggage propagator already uses decode_utf8() and logs invalid UTF-8 instead of doing lossy decoding, so this new path should probably follow that shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #857
Changes
$OTEL_RESOURCE_ATTRIBUTESvalues are now percent-decoded in line with the spec.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes