fix(appender-tracing): always normalize event metadata when experimental_metadata_attributes is enabled#3582
Open
dquirl-R1 wants to merge 2 commits into
Open
fix(appender-tracing): always normalize event metadata when experimental_metadata_attributes is enabled#3582dquirl-R1 wants to merge 2 commits into
experimental_metadata_attributes is enabled#3582dquirl-R1 wants to merge 2 commits into
Conversation
…ntal_metadata_attributes` is enabled Works on open-telemetry#3543
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3582 +/- ##
=======================================
- Coverage 83.0% 83.0% -0.1%
=======================================
Files 130 130
Lines 28064 28063 -1
=======================================
- Hits 23321 23320 -1
Misses 4743 4743 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Thank you for your contribution! This PR has been automatically marked as stale because it has not had activity in the last 14 days. This may be due to a delay in review on our side or awaiting a response from you; either is fine, and we appreciate your patience. It will be closed in 14 days if no further activity occurs. Pushing a new commit or leaving a comment will remove the stale label and keep the PR open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3543
Design discussion issue (if applicable) #Changes
Consistently applies
NormalizeEventif theexperimental_metadata_attributesfeature is active to ensure that the generated log records that are emitted forward the originallog.targetas the log event target instead of defaulting to"log".The change impacts all extracted metadata, not just the target. It also applies to
severity,targetandnameused to check ifself.logger.event_enabled(cf. Fix OTel Appender for tracing from suppressing other layers #2668, feat: Allow event name to be provided to IsEnabled check in Logger #2756)severitynumber set on the log record itselflevelIt does not affect the behaviour of
EnvFilter, because of the interaction betweentracing-lognormalizing throughAsTrace(a different normalization) before callingenabledon the dispatcher indispatch_recordand the wayEnvFiltercachesFilterStateand doesn't useevent_enabled(see also #3543 (comment)).Note that this reverts #2799 as the optimization is incompatible with applying normalization before setting the target.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes