Skip to content

feat(api): accept quoted-key fields in otel logging macros #3567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cijothomas merged 3 commits into from
Jun 25, 2026
+6 −4
Merged

feat(api): accept quoted-key fields in otel logging macros #3567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ec2fe3
feat(api): accept quoted-key fields in otel logging macros
cijothomas Jun 23, 2026
6a63d55
docs: add changelog entry for quoted-key macro support
cijothomas Jun 25, 2026
7c3b0d8
Merge remote-tracking branch 'origin/main' into cijothomas/otel-macro…
cijothomas Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions opentelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## vNext

- `otel_info!`, `otel_warn!`, `otel_debug!`, and `otel_error!` macros now accept quoted-key fields
(e.g. `"otel.component.type" = "value"`) for dotted attribute names.
- **Added** `BoundGauge<T>` and `BoundUpDownCounter<T>` types (and the
corresponding `Gauge::bind()` / `UpDownCounter::bind()` methods), completing
the experimental bound-instrument API across all sync instruments
Expand Down
8 changes: 4 additions & 4 deletions opentelemetry/src/global/internal_logging.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ macro_rules! otel_info {
let _ = $name; // Compiler will optimize this out as it's unused.
}
};
(name: $name:expr, $($key:ident = $value:expr),+ $(,)?) => {
(name: $name:expr, $($key:tt = $value:expr),+ $(,)?) => {
#[cfg(feature = "internal-logs")]
{
$crate::_private::info!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, $($key = $value),+);
Expand Down Expand Up @@ -90,7 +90,7 @@ macro_rules! otel_warn {
let _ = $name; // Compiler will optimize this out as it's unused.
}
};
(name: $name:expr, $($key:ident = $value:expr),+ $(,)?) => {
(name: $name:expr, $($key:tt = $value:expr),+ $(,)?) => {
#[cfg(feature = "internal-logs")]
{
$crate::_private::warn!(name: $name,
Expand Down Expand Up @@ -147,7 +147,7 @@ macro_rules! otel_debug {
let _ = $name; // Compiler will optimize this out as it's unused.
}
};
(name: $name:expr, $($key:ident = $value:expr),+ $(,)?) => {
(name: $name:expr, $($key:tt = $value:expr),+ $(,)?) => {
#[cfg(feature = "internal-logs")]
{
$crate::_private::debug!(name: $name, target: env!("CARGO_PKG_NAME"), name = $name, $($key = $value),+);
Expand Down Expand Up @@ -198,7 +198,7 @@ macro_rules! otel_error {
let _ = $name; // Compiler will optimize this out as it's unused.
}
};
(name: $name:expr, $($key:ident = $value:expr),+ $(,)?) => {
(name: $name:expr, $($key:tt = $value:expr),+ $(,)?) => {
#[cfg(feature = "internal-logs")]
{
$crate::_private::error!(name: $name,
Expand Down
Loading