feat(sdk): add otel.sdk.log.created self-observability metric#3530
feat(sdk): add otel.sdk.log.created self-observability metric#3530cijothomas wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3530 +/- ##
=======================================
- Coverage 83.2% 83.1% -0.1%
=======================================
Files 130 130
Lines 28246 28289 +43
=======================================
+ Hits 23506 23517 +11
- Misses 4740 4772 +32 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Need to make some tweaks before merging. |
|
Thank you for your contribution! This PR has been automatically marked as stale because it has not had activity in the last 14 days. This may be due to a delay in review on our side or awaiting a response from you; either is fine, and we appreciate your patience. It will be closed in 14 days if no further activity occurs. Pushing a new commit or leaving a comment will remove the stale label and keep the PR open. |
|
Closed as inactive. Thank you again for the contribution; please feel free to reopen this PR (or open a new one) if you'd like to continue the work. |
Increments a u64 counter on every SdkLogger::emit call that passes the telemetry-suppression check. Bound once per SdkLogger with no attributes, per the OpenTelemetry semantic conventions for SDK metrics. Gated behind the experimental_metrics_bound_instruments Cargo feature for consistency with the existing otel.sdk.processor.log.processed metric; the semconv for otel.sdk.log.created is still development.
48ded96 to
cff45b8
Compare
cff45b8 to
8fb6833
Compare
Changes
Adds the
otel.sdk.log.createdself-observability metric to the Logs SDK.A
u64counter is bound once perSdkLogger(no attributes) and incrementedon every
emitcall that passes the telemetry-suppression check.Merge requirement checklist
(in-progress: ci: add weaver live-check workflow for tower instrumentation (seed for #530) opentelemetry-rust-contrib#613).
SDK control-flow paths (suppression early-return, post-shutdown
no-op routing) are exercised by existing tests.
CHANGELOG.md/ N/ANotes
experimental_metrics_bound_instrumentsCargo feature,matching the existing
otel.sdk.processor.log.processedmetric. Thesemconv definition is still
stability: development.after the per-emit gates and before processor dispatch. Rust's
telemetry-suppression early-return is SDK-specific; no other reference
SDK has an equivalent concept.