[opentelemetry-resourcedetector-gcp] Fix directory structure and version number#4861
Open
DylanRussell wants to merge 4 commits into
Open
[opentelemetry-resourcedetector-gcp] Fix directory structure and version number#4861DylanRussell wants to merge 4 commits into
opentelemetry-resourcedetector-gcp] Fix directory structure and version number#4861DylanRussell wants to merge 4 commits into
Conversation
# Conflicts: # resource/opentelemetry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/version.py
Contributor
|
Good to change it back in this PR. Can discuss namespacing and major release later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved source package from
src/opentelemetry/resource/detector/gcp/tosrc/opentelemetry/resourcedetector/gcp_resource_detector/.Updated package namespace from
opentelemetry.resource.detector.gcptoopentelemetry.resourcedetector.gcp_resource_detector.This matches the directory structure and namespace in https://github.com/GoogleCloudPlatform/opentelemetry-operations-python/tree/main/opentelemetry-resourcedetector-gcp , which we want to do to avoid breaking people..
I didn't mean to change the directory structure in the first place. My agent did it and I didn't notice..
If it's important to match the directory structure used in this repo we could also leave it as it is now (revert this change), but add a compatibility shim (re-import
GoogleCloudResourceDetector) under the existing path:src/opentelemetry/resourcedetector/gcp_resource_detector/sinceGoogleCloudResourceDetectoris the only public object in this package.Let me know what y'all think...
Also I've fixed the version number in this PR (added the
a0suffix back) so the next release will be1.14.0a0-- this matches how we were doing it in the old repo..Fixes #4855
How Has This Been Tested?
Unit tests
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.