Skip to content

[opentelemetry-resourcedetector-gcp] Fix directory structure and version number#4861

Open
DylanRussell wants to merge 4 commits into
open-telemetry:mainfrom
DylanRussell:fix-resource-detector
Open

[opentelemetry-resourcedetector-gcp] Fix directory structure and version number#4861
DylanRussell wants to merge 4 commits into
open-telemetry:mainfrom
DylanRussell:fix-resource-detector

Conversation

@DylanRussell

@DylanRussell DylanRussell commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Description

Moved source package from src/opentelemetry/resource/detector/gcp/ to src/opentelemetry/resourcedetector/gcp_resource_detector/.

Updated package namespace from opentelemetry.resource.detector.gcp to opentelemetry.resourcedetector.gcp_resource_detector.

This matches the directory structure and namespace in https://github.com/GoogleCloudPlatform/opentelemetry-operations-python/tree/main/opentelemetry-resourcedetector-gcp , which we want to do to avoid breaking people..

I didn't mean to change the directory structure in the first place. My agent did it and I didn't notice..

If it's important to match the directory structure used in this repo we could also leave it as it is now (revert this change), but add a compatibility shim (re-import GoogleCloudResourceDetector) under the existing path: src/opentelemetry/resourcedetector/gcp_resource_detector/ since GoogleCloudResourceDetector is the only public object in this package.

Let me know what y'all think...

Also I've fixed the version number in this PR (added the a0 suffix back) so the next release will be 1.14.0a0 -- this matches how we were doing it in the old repo..

Fixes #4855

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@DylanRussell
DylanRussell requested a review from a team as a code owner July 23, 2026 15:13
# Conflicts:
#	resource/opentelemetry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/version.py
@tammy-baylis-swi tammy-baylis-swi moved this to Ready for review in Python PR digest Jul 23, 2026
@tammy-baylis-swi

Copy link
Copy Markdown
Contributor

Good to change it back in this PR. Can discuss namespacing and major release later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Ready for review

Development

Successfully merging this pull request may close these issues.

opentelemetry-resourcedetector-gcp 1.13.0: unmarked breaking import path rename breaks gcp-trace exporter

2 participants