Skip to content

Re-enable PyPy botocore test matrix#4841

Open
anneheartrecord wants to merge 3 commits into
open-telemetry:mainfrom
anneheartrecord:fix/pypy-botocore-1736
Open

Re-enable PyPy botocore test matrix#4841
anneheartrecord wants to merge 3 commits into
open-telemetry:mainfrom
anneheartrecord:fix/pypy-botocore-1736

Conversation

@anneheartrecord

@anneheartrecord anneheartrecord commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description

Re-enable the current PyPy tox matrix for opentelemetry-instrumentation-botocore.

The old failure path from #1736 was tied to dependencies that were later removed from the botocore test requirements. The current PyPy botocore environments now install and pass locally, so this restores CI coverage for those combinations.

Fixes #1736

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • tox -e generate-workflows
  • tox --exit-and-dump-after 1800 run -e pypy3-test-instrumentation-botocore-0-wrapt1,pypy3-test-instrumentation-botocore-0-wrapt2,pypy3-test-instrumentation-botocore-1-wrapt1,pypy3-test-instrumentation-botocore-1-wrapt2,pypy3-test-instrumentation-botocore-2,pypy3-test-instrumentation-botocore-3 -- -q

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Post-Deploy Monitoring & Validation

No additional operational monitoring required; this only changes the contrib repository's test matrix.

@anneheartrecord
anneheartrecord marked this pull request as ready for review July 20, 2026 04:25
@anneheartrecord
anneheartrecord requested a review from a team as a code owner July 20, 2026 04:25
Comment thread tox.ini Outdated
Comment on lines +98 to +99
pypy3-test-instrumentation-botocore-{0,1}-{wrapt1,wrapt2}
pypy3-test-instrumentation-botocore-{2,3}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd pick just one environment for botocore and one for aiobotocore

@anneheartrecord

Copy link
Copy Markdown
Contributor Author

@xrmx Done in 55e0d76 for #4841 (comment). I kept one PyPy botocore env (pypy3-test-instrumentation-botocore-1-wrapt2) and one aiobotocore env (pypy3-test-instrumentation-botocore-3), then regenerated test.yml.

Local checks:

  • uvx tox -e generate-workflows
  • uvx tox --exit-and-dump-after 1800 run -e pypy3-test-instrumentation-botocore-1-wrapt2,pypy3-test-instrumentation-botocore-3 -- -q
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

CI: Fatal Python error: Aborted

2 participants