Psycopg semconv optin tests#4838
Open
henry3260 wants to merge 2 commits into
Open
Conversation
…est coverage Cover database,http and database/dup,http/dup opt-in modes for both the sync and async connection paths, verifying stable-only and dual-emission span attributes, mirroring the pattern from open-telemetry#4810.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since psycopg instruments both sync and async connection paths, this adds four
tests mirroring the merged mysql (#4810) / mysqlclient (#4834) pattern:
test_semconv_stable/test_semconv_stable_async(database,http):assert only stable attributes are emitted (
db.system.name,db.namespace,db.query.text,server.address,server.port) and legacy ones(
db.system,db.name,db.statement,db.user,net.peer.*) are absenttest_semconv_dup/test_semconv_dup_async(database/dup,http/dup):assert both legacy and stable attributes are emitted with correct values
Since psycopg maps connection attributes through the nested
infoobject(
info.dbname,info.host,info.port,info.user), the existing mockconnections are extended with
MockConnectionWithInfoandMockAsyncConnectionWithInfoto expose them.Type of change
How Has This Been Tested?
tox -e py312-test-instrumentation-psycopg-1— 25 passed, 3 skipped (21 existing + 4 new; skips are pre-existing t-string tests requiring Python 3.14+)tox -e lint-instrumentation-psycopg— pylint 10.00/10pre-commit run ruff/ruff-format— cleanDoes This PR Require a Core Repo Change?
Checklist: