fix(redis): treat explicit db=None as database index 0#4828
Open
ahmed5145 wants to merge 2 commits into
Open
Conversation
herin049
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RedisInstrumentorreads the database index from the connection'sconnection_kwargsviaconn_kwargs.get("db", 0).dict.getonly fallsback to the default when the key is missing — if
dbis present and set toNone(which redis-py allows, e.g.Redis(..., db=None)or somefrom_urlpaths), the value stays
None. ThatNonewas then passed straight to thedatabase-index attribute, producing:
Invalid type NoneType for attribute 'db.redis.database_index' value. Expected one of ['bool', 'str', 'bytes', 'int', 'float'] or a sequence of those types
This coerces an explicit
db=Noneto0(Redis' default database), in both_extract_conn_attributesand the pipeline span-name fallback in_build_span_name, so no invalid attribute is emitted.Fixes #1905
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
test_attributes_db_none, which setsdb=Nonein the client'sconnection kwargs and asserts the span reports
db.redis.database_index == 0with no invalid-attribute warning.
test_attributes_db_noneand
test_attributes_defaultpass).Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.