fix(celery): populate origin and hostname as distinct span attributes#4827
Open
ahmed5145 wants to merge 2 commits into
Open
fix(celery): populate origin and hostname as distinct span attributes#4827ahmed5145 wants to merge 2 commits into
ahmed5145 wants to merge 2 commits into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Celery's
set_attributes_from_contextaliasedorigintohostname, so onprefork workers the worker-thread origin (e.g.
gen8@host) overwrote the realworker hostname (e.g.
celery@host) in thecelery.hostnamespan attribute.Metrics already used the correct hostname (
task.request.hostname), so spansand metrics disagreed. This drops the alias so
celery.originandcelery.hostnameare emitted as distinct span attributes, matching the actualCelery request fields.
Fixes #3096
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -r -e py314-test-instrumentation-celery(30 passed) on Windows /Python 3.14 against core commit
d9f34e7.test_set_attributes_from_contextto assert that a contextcontaining both
originandhostnamesetscelery.originandcelery.hostnameto their own values independently.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.