Check conventions formatting in CI#19295
Open
trask wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds CI formatting validation for the separate conventions Gradle build and applies required formatting fixes.
Changes:
- Runs
spotlessCheckfor the conventions build. - Applies Spotless formatting without behavioral changes.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/build-common.yml |
Checks conventions formatting in CI. |
conventions/src/main/kotlin/otel.resolve-latest-dep-versions.gradle.kts |
Applies Kotlin formatting. |
conventions/src/main/kotlin/otel.java-conventions.gradle.kts |
Applies naming and formatting fixes. |
conventions/src/main/kotlin/otel.japicmp-conventions.gradle.kts |
Corrects indentation. |
conventions/src/main/kotlin/io.opentelemetry.instrumentation.base.gradle.kts |
Applies comment and interpolation formatting. |
trask
marked this pull request as ready for review
July 22, 2026 17:07
Pull request dashboard statusStatus last refreshed: 2026-07-24 10:58:57 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
jaydeluca
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root
spotlessChecktask does not check theconventionsdirectory because it is a separate included Gradle build. As a result, formatting violations in convention plugins are currently not caught by CI.