Update host id resource detector for macos and full paths#19293
Open
jaydeluca wants to merge 2 commits into
Open
Update host id resource detector for macos and full paths#19293jaydeluca wants to merge 2 commits into
jaydeluca wants to merge 2 commits into
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-23 14:31:21 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates host ID detection to align with OS-specific semantic convention guidance.
Changes:
- Adds macOS and BSD host ID detection.
- Adds Linux fallback and absolute command paths.
- Expands OS-specific tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
HostIdResource.java |
Implements expanded cross-platform host ID detection. |
HostIdResourceTest.java |
Adds Linux fallback, macOS, and BSD tests. |
jaydeluca
marked this pull request as ready for review
July 22, 2026 15:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was working on adding this resource detector to python and was referencing this implementation and found some things that could be updated