Skip to content

Harden draft release note generation #19281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trask wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −1
Open

Harden draft release note generation #19281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7367a7
Fix release note reference extraction
trask Jul 21, 2026
24be3d9
Require escaped classifier JSON
trask Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/scripts/draft-release-notes/fetch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,10 @@
SRC_MAIN_JAVA_PATHSPEC = "*/src/main/**/*.java"
PR_SUFFIX_RE = re.compile(r"\s*\(#(\d+)\)$")
VERSION_RE = re.compile(r'val stableVersion = "(\d+\.\d+\.\d+)')
ISSUE_REF_RE = re.compile(r"(?:issues|pull)/(\d+)|(?<![A-Za-z0-9/])#(\d+)\b")
ISSUE_REF_RE = re.compile(
rf"https?://github\.com/{re.escape(REPO)}/(?:issues|pull)/([1-9]\d*)\b"
r"|(?<![A-Za-z0-9/])#([1-9]\d*)\b"
)
GH_FETCH_WORKERS = 8
GH_FETCH_RETRIES = 3
GH_FETCH_RETRY_DELAY = 5.0
Expand Down
5 changes: 5 additions & 0 deletions .github/scripts/draft-release-notes/rules.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ by the parser but discouraged — prefer a bare JSON object:
}
```

The response must be parseable by `json.loads`. JSON-escape every special
character in string values, including `"` as `\"`, `\` as `\\`, and newlines
as `\n`. Pay particular attention to Java string literals copied into
`evidence`, and verify the complete object is valid JSON before responding.

## Core rule

Classify every PR from its diff only. PR titles, manifest `subject`,
Expand Down
Loading