Migrate RocketMQ messaging telemetry to v1.43 preview#19275
Draft
trask wants to merge 4 commits into
Draft
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-22 18:26:25 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
This was referenced Jul 19, 2026
trask
force-pushed
the
messaging-v1-43-rocketmq
branch
from
July 19, 2026 20:35
21649b9 to
9e709c5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates RocketMQ 4.8 and 5.0 telemetry to the v1.43 messaging preview using the shared topology from #19268.
Changes:
- Updates RocketMQ span names, kinds, attributes, parenting, links, and error types.
- Adds preview and dual-emission test configurations.
- Extends shared messaging APIs, metrics, span keys, and tests.
Reviewed changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
testing-common/.../SemconvMessagingStabilityUtil.java |
Adds test attribute-key mapping. |
rocketmq-client-5.0/.../AbstractRocketMqClientTest.java |
Updates v1.43 assertions. |
rocketmq-client-5.0/.../RocketMqInstrumenterFactory.java |
Adopts shared messaging topology. |
rocketmq-client-5.0/.../RocketMqConsumerProcessAttributeGetter.java |
Extracts failure type. |
rocketmq-client-5.0/.../ReceiveSpanFinishingCallback.java |
Adjusts process parenting. |
rocketmq-client-5.0/javaagent/build.gradle.kts |
Adds preview and dual tests. |
rocketmq-client-4.8/.../AbstractRocketMqClientTest.java |
Updates messaging assertions. |
rocketmq-client-4.8/.../RocketMqInstrumenterFactory.java |
Migrates span construction. |
rocketmq-client-4.8/.../RocketMqConsumerInstrumenter.java |
Changes batch process parents. |
rocketmq-client-4.8/library/build.gradle.kts |
Adds preview testing. |
rocketmq-client-4.8/javaagent/build.gradle.kts |
Adds preview testing. |
.../AgentSpanTestingInstrumenter.java |
Includes new span keys. |
.../ContextBridgeTest.java |
Tests new bridged keys. |
.../SpanKeyBridging.java |
Bridges optional messaging keys. |
instrumentation-api/.../SemconvStabilityTest.java |
Tests messaging selection modes. |
instrumentation-api/.../SpanKey.java |
Adds create and settle keys. |
instrumentation-api/.../SemconvStability.java |
Clarifies messaging preview naming. |
.../MessagingSpanNameExtractorTest.java |
Expands span-name coverage. |
.../MessagingSpanKindExtractorTest.java |
Tests v1.43 span kinds. |
.../MessagingProducerMetricsTest.java |
Tests producer metrics. |
.../MessagingProcessMetricsTest.java |
Tests process duration. |
.../MessagingMetricsAdviceTest.java |
Tests cardinality filtering. |
.../MessagingConsumerMetricsTest.java |
Tests consumer metrics. |
.../MessagingAttributesExtractorTest.java |
Tests v1.43 extraction. |
.../MessagingProcessInstrumenterFactoryTest.java |
Tests topology selection. |
.../MessagingProcessContextCustomizerTest.java |
Tests process parenting. |
.../MessagingSpanNameExtractorBuilder.java |
Adds configurable operation names. |
.../MessagingSpanNameExtractor.java |
Implements v1.43 naming. |
.../MessagingSpanKindExtractor.java |
Implements messaging span kinds. |
.../MessagingProducerMetrics.java |
Adds v1.43 producer metrics. |
.../MessagingProcessMetrics.java |
Adds process metrics. |
.../MessagingOperationType.java |
Defines v1.43 operation types. |
.../MessagingMetricsAdvice.java |
Defines metric attribute advice. |
.../MessagingConsumerMetrics.java |
Adds v1.43 consumer metrics. |
.../MessagingAttributesGetter.java |
Adds error-type extraction. |
.../MessagingAttributesExtractorBuilder.java |
Supports operation names/types. |
.../MessagingAttributesExtractor.java |
Emits version-specific attributes. |
.../MessageOperation.java |
Maps legacy operations to new types. |
.../MessagingProcessInstrumenterFactory.java |
Centralizes process topology. |
.../MessagingProcessContextCustomizer.java |
Preserves ambient process parents. |
instrumentation-api-incubator/build.gradle.kts |
Enables messaging preview tests. |
trask
force-pushed
the
messaging-v1-43-rocketmq
branch
from
July 20, 2026 15:27
6d62ccd to
1036e29
Compare
trask
force-pushed
the
messaging-v1-43-rocketmq
branch
from
July 20, 2026 15:59
d6fb6be to
f6c52ab
Compare
trask
force-pushed
the
messaging-v1-43-rocketmq
branch
from
July 21, 2026 06:58
fc3e525 to
a4ab509
Compare
trask
force-pushed
the
messaging-v1-43-rocketmq
branch
from
July 21, 2026 07:02
a4ab509 to
b2a1147
Compare
trask
force-pushed
the
messaging-v1-43-rocketmq
branch
from
July 21, 2026 13:36
b2a1147 to
b972c89
Compare
trask
force-pushed
the
messaging-v1-43-rocketmq
branch
from
July 21, 2026 14:09
b972c89 to
a7bc8a7
Compare
trask
force-pushed
the
messaging-v1-43-rocketmq
branch
from
July 21, 2026 17:42
a7bc8a7 to
a5ef24f
Compare
trask
force-pushed
the
messaging-v1-43-rocketmq
branch
from
July 22, 2026 17:59
a5ef24f to
a9282cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #19268.
Dependency baseline:
9b5ec57607668f417ce57a15c2281897fcb3f774.Review only:
9b5ec57607668f417ce57a15c2281897fcb3f774..a9282cc1f0a1de80f646fd21b3b5ecaa4915b642.Exactly one RocketMQ commit. RocketMQ 4.8 and 5.0 use typed stable/dual topology; the 4.8 implementation and testing preserve declared 4.0 through 5.x compatibility and keep batch counts stable-only. Namespace accessor reflection is cached per context class, including absent methods on older supported clients, so namespace lookup does not use exception-driven per-operation control flow.
Validated: RocketMQ 4.8 full library and javaagent checks, focused namespace accessor cache tests, muzzle, default batch regressions, stable/dual suites, exact latest-dependencies integration class, and Spotless; RocketMQ 5.0 stable/dual suites.