Migrate Pulsar messaging telemetry to v1.43 preview#19273
Draft
trask wants to merge 4 commits into
Draft
Conversation
Pull request dashboard statusStatus last refreshed: 2026-07-22 16:49:42 UTC.
This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected. |
This was referenced Jul 19, 2026
trask
force-pushed
the
messaging-v1-43-pulsar
branch
from
July 19, 2026 20:35
2df4130 to
97b5ee2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates Pulsar and Spring Pulsar telemetry to the shared messaging v1.43 preview infrastructure.
Changes:
- Updates span naming, kinds, parenting, links, and metrics.
- Adds old, preview, and dual-emission assertions.
- Adds preview-mode Gradle test tasks.
Reviewed changes
Copilot reviewed 40 out of 40 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
instrumentation/pulsar/pulsar-2.8/javaagent/build.gradle.kts |
Adds preview and dual-emission test tasks. |
instrumentation/pulsar/pulsar-2.8/javaagent/src/main/java/.../PulsarSingletons.java |
Migrates Pulsar instrumenters and context propagation. |
instrumentation/pulsar/pulsar-2.8/javaagent/src/test/java/.../AbstractPulsarClientTest.java |
Adapts shared assertions for both conventions. |
instrumentation/pulsar/pulsar-2.8/javaagent/src/test/java/.../PulsarClientTest.java |
Updates span and metric expectations. |
instrumentation/spring/spring-pulsar-1.0/javaagent/build.gradle.kts |
Adds preview-mode testing. |
instrumentation/spring/spring-pulsar-1.0/javaagent/src/main/java/.../SpringPulsarSingletons.java |
Uses the shared process instrumenter factory. |
instrumentation/spring/spring-pulsar-1.0/javaagent/src/test/java/.../SpringPulsarTest.java |
Updates preview span expectations. |
instrumentation/spring/spring-pulsar-1.0/javaagent/src/testReceiveSpansDisabled/java/.../SpringPulsarSuppressReceiveSpansTest.java |
Adds convention-dependent assertions. |
instrumentation/spring/spring-pulsar-1.0/testing/src/main/java/.../AbstractSpringPulsarTest.java |
Supports old and preview operation attributes. |
trask
force-pushed
the
messaging-v1-43-pulsar
branch
from
July 20, 2026 15:48
62cf466 to
3894439
Compare
trask
force-pushed
the
messaging-v1-43-pulsar
branch
from
July 21, 2026 05:22
3894439 to
0b319a5
Compare
trask
force-pushed
the
messaging-v1-43-pulsar
branch
from
July 21, 2026 05:37
0b319a5 to
3784f77
Compare
trask
force-pushed
the
messaging-v1-43-pulsar
branch
from
July 21, 2026 14:25
9641d71 to
adf131f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 43 out of 43 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
instrumentation/spring/spring-pulsar-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/spring/pulsar/v1_0/SpringPulsarSingletons.java:40
- [General] The fallback is aliased away whenever receive telemetry is globally enabled, even when core Pulsar instrumentation is disabled or its receive instrumenter does not start. In that case
wasReceiveTelemetryRecorded(message)is false, but selectinginstrumenterWithConsumedMessagesstill records no consumed-message metric. Build the fallback variant whenever stable messaging semconv is active; the per-message marker already prevents duplicate recording.
trask
force-pushed
the
messaging-v1-43-pulsar
branch
from
July 21, 2026 16:44
adf131f to
5269169
Compare
trask
force-pushed
the
messaging-v1-43-pulsar
branch
from
July 21, 2026 17:00
5269169 to
a7cb95e
Compare
trask
force-pushed
the
messaging-v1-43-pulsar
branch
from
July 21, 2026 17:42
a7cb95e to
75aaf92
Compare
trask
force-pushed
the
messaging-v1-43-pulsar
branch
from
July 22, 2026 02:15
75aaf92 to
6b35cca
Compare
trask
force-pushed
the
messaging-v1-43-pulsar
branch
from
July 22, 2026 03:15
6b35cca to
2fe52dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #19268.
Dependency baseline:
9b5ec57607668f417ce57a15c2281897fcb3f774.Review only:
9b5ec57607668f417ce57a15c2281897fcb3f774..2fe52dc7cb1a23690d1af7b8270c50914971daed.Exactly one Pulsar commit. Pulsar and Spring Pulsar use typed telemetry; Spring always provides a stable consumed fallback and selects it only when core receive telemetry did not mark the message. Stable metric assertions follow pinned v1.43 advice. Receive-enabled stable tests cover listener process spans in producer traces, separate linked receive roots, and root async callbacks.
Validated: full Pulsar javaagent
check; focused stable receive-enabled topology under default and latest dependencies; Pulsar stable/dual/latest-deps receive-disabled suites; Spring Pulsar enabled/disabled suites; cross-scope consumed-metric deduplication; and Spotless.