Skip to content

Migrate JMS NATS and Spring messaging telemetry to v1.43 preview#19272

Draft
trask wants to merge 4 commits into
open-telemetry:mainfrom
trask:messaging-v1-43-jms-nats-spring
Draft

Migrate JMS NATS and Spring messaging telemetry to v1.43 preview#19272
trask wants to merge 4 commits into
open-telemetry:mainfrom
trask:messaging-v1-43-jms-nats-spring

Conversation

@trask

@trask trask commented Jul 19, 2026

Copy link
Copy Markdown
Member

Depends on #19268.

Dependency baseline: 9b5ec57607668f417ce57a15c2281897fcb3f774.
Review only: 9b5ec57607668f417ce57a15c2281897fcb3f774..1a2d8820ffabbeaf6d8fa02fbe806cd9ba5b9004.

Exactly one JMS/NATS/Spring commit with typed builders and final shared metrics/topology. Legacy semconv suppression in the Spring Integration test helper is scoped to the single method that directly references deprecated constants.

Validated: Spring Integration testing module full check and Spotless, family compilation, and stable Spring JMS topology test.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 19, 2026

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-22 20:53:39 UTC.

  • Waiting on: Author
  • Next step: Move out of draft to request review.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates shared messaging telemetry plus JMS, NATS, Spring JMS, and Spring Integration instrumentation to the v1.43 preview semantic conventions.

Changes:

  • Adds v1.43 messaging attributes, names, kinds, metrics, span keys, and process topology support.
  • Migrates JMS, NATS, and Spring messaging instrumentation and assertions.
  • Adds preview and dual-emission test tasks.

Reviewed changes

Copilot reviewed 65 out of 65 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
testing-common/.../SemconvMessagingStabilityUtil.java Maps legacy test attribute keys.
spring-jms-6.0/.../SpringJmsListenerTest.java Updates listener assertions for preview telemetry.
spring-jms-6.0/javaagent/build.gradle.kts Adds preview test task.
spring-jms-2.0/.../AbstractJmsTest.java Adapts shared JMS assertions.
spring-jms-2.0/.../SpringTemplateTest.java Updates preview span ordering.
spring-jms-2.0/.../SpringListenerTest.java Handles preview receive span kind.
spring-jms-2.0/javaagent/build.gradle.kts Adds preview test task.
spring-integration-4.1/.../SpringIntegrationTestHelper.java Adds semantic-convention assertion helpers.
spring-integration-4.1/.../AbstractSpringIntegrationTracingTest.java Validates preview names and attributes.
spring-integration-4.1/.../AbstractSpringCloudStreamRabbitTest.java Updates Rabbit flow assertions.
spring-integration-4.1/.../AbstractSpringCloudStreamProducerTest.java Updates producer flow assertions.
spring-integration-4.1/.../AbstractComplexPropagationTest.java Updates chained-channel assertions.
spring-integration-4.1/metadata.yaml Declares messaging span conventions.
spring-integration-4.1/.../SpringMessagingAttributesGetter.java Supplies preview messaging metadata.
spring-integration-4.1/.../SpringIntegrationTelemetryBuilder.java Uses new process topology and operation APIs.
spring-integration-4.1/library/build.gradle.kts Adds library preview tests.
spring-integration-4.1/javaagent/build.gradle.kts Adds agent preview tests.
opentelemetry-instrumentation-api-1.14/.../AgentSpanTestingInstrumenter.java Includes new bridged span keys.
opentelemetry-instrumentation-api-1.14/.../ContextBridgeTest.java Tests new span-key bridging.
opentelemetry-instrumentation-api-1.14/.../SpanKeyBridging.java Bridges optional messaging span keys.
nats-2.17/.../NatsTestHelper.java Adds preview NATS assertions.
nats-2.17/.../AbstractNatsRequestTest.java Updates request/reply telemetry assertions.
nats-2.17/.../AbstractNatsPublishTest.java Updates publish span names.
nats-2.17/.../AbstractNatsDispatcherTest.java Updates dispatcher span names.
nats-2.17/.../NatsInstrumenterFactory.java Migrates operation and process instrumentation.
nats-2.17/library/build.gradle.kts Adds library preview tests.
nats-2.17/javaagent/build.gradle.kts Adds agent preview tests.
jms-common-1.1/.../JmsReceiveSpanUtil.java Changes receive-context handoff.
jms-common-1.1/.../JmsInstrumenterFactory.java Migrates JMS names, kinds, and topology.
jms-3.0/.../Jms3SuppressReceiveSpansTest.java Updates suppression assertions.
jms-3.0/.../Jms3InstrumentationTest.java Updates receive telemetry assertions.
jms-3.0/.../AbstractJms3Test.java Adds preview JMS 3 assertions.
jms-3.0/javaagent/build.gradle.kts Adds preview test task.
jms-1.1/.../Jms1SuppressReceiveSpansTest.java Updates suppression assertions.
jms-1.1/.../Jms1InstrumentationTest.java Updates receive telemetry assertions.
jms-1.1/.../AbstractJms1Test.java Adds preview JMS 1 assertions.
jms-1.1/.../Jms2InstrumentationTest.java Adds preview JMS 2 assertions.
jms-1.1/javaagent/build.gradle.kts Adds preview and dual-emission tests.
instrumentation-api/.../SemconvStabilityTest.java Tests messaging selection matrix.
instrumentation-api/.../SpanKey.java Adds create and settle span keys.
instrumentation-api/.../SemconvStability.java Clarifies messaging mode helpers.
instrumentation-api-incubator/.../MessagingSpanNameExtractorTest.java Expands preview naming coverage.
instrumentation-api-incubator/.../MessagingSpanKindExtractorTest.java Tests operation-specific kinds.
instrumentation-api-incubator/.../MessagingProducerMetricsTest.java Tests producer preview metrics.
instrumentation-api-incubator/.../MessagingProcessMetricsTest.java Tests processing duration metric.
instrumentation-api-incubator/.../MessagingMetricsAdviceTest.java Tests cardinality filtering.
instrumentation-api-incubator/.../MessagingConsumerMetricsTest.java Tests consumer preview metrics.
instrumentation-api-incubator/.../MessagingAttributesExtractorTest.java Expands attribute extraction coverage.
instrumentation-api-incubator/.../MessagingProcessInstrumenterFactoryTest.java Tests process parenting and links.
instrumentation-api-incubator/.../MessagingProcessContextCustomizerTest.java Tests ambient and producer contexts.
instrumentation-api-incubator/.../MessagingSpanNameExtractorBuilder.java Adds configurable naming builder.
instrumentation-api-incubator/.../MessagingSpanNameExtractor.java Implements v1.43 span naming.
instrumentation-api-incubator/.../MessagingSpanKindExtractor.java Implements v1.43 span kinds.
instrumentation-api-incubator/.../MessagingProducerMetrics.java Adds preview producer metrics.
instrumentation-api-incubator/.../MessagingProcessMetrics.java Adds process duration metrics.
instrumentation-api-incubator/.../MessagingOperationType.java Defines v1.43 operation types.
instrumentation-api-incubator/.../MessagingMetricsAdvice.java Defines metric attributes and filtering.
instrumentation-api-incubator/.../MessagingConsumerMetrics.java Adds preview consumer metrics.
instrumentation-api-incubator/.../MessagingAttributesGetter.java Adds error-type extraction.
instrumentation-api-incubator/.../MessagingAttributesExtractorBuilder.java Supports operation names and types.
instrumentation-api-incubator/.../MessagingAttributesExtractor.java Emits preview messaging attributes.
instrumentation-api-incubator/.../MessageOperation.java Maps legacy operations to new types.
instrumentation-api-incubator/.../MessagingProcessInstrumenterFactory.java Centralizes process topology construction.
instrumentation-api-incubator/.../MessagingProcessContextCustomizer.java Selects ambient or producer context.
instrumentation-api-incubator/build.gradle.kts Enables preview modes in test suites.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-jms-nats-spring branch from 09b686d to 5e0e1d6 Compare July 20, 2026 02:23
@trask
trask requested a review from Copilot July 20, 2026 02:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated 1 comment.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated 1 comment.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-jms-nats-spring branch from da9a7d0 to 05da605 Compare July 20, 2026 15:48
@trask
trask requested a review from Copilot July 20, 2026 15:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-jms-nats-spring branch from 05da605 to 1976cf8 Compare July 21, 2026 04:51
@trask
trask requested a review from Copilot July 21, 2026 04:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-jms-nats-spring branch from 90d4009 to f9edfd7 Compare July 21, 2026 06:48
@trask
trask requested a review from Copilot July 21, 2026 06:50
@trask
trask force-pushed the messaging-v1-43-jms-nats-spring branch from f9edfd7 to 14f1346 Compare July 21, 2026 06:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-jms-nats-spring branch from 14f1346 to 9fa3299 Compare July 21, 2026 07:02
@trask
trask requested a review from Copilot July 21, 2026 07:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-jms-nats-spring branch from 9fa3299 to 090c0d1 Compare July 21, 2026 17:42
@trask
trask requested a review from Copilot July 21, 2026 17:43

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-jms-nats-spring branch from 090c0d1 to 1a2d882 Compare July 22, 2026 19:31
@trask
trask requested a review from Copilot July 22, 2026 19:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated 1 comment.

@trask
trask force-pushed the messaging-v1-43-jms-nats-spring branch 3 times, most recently from 1a2d882 to 9830e5f Compare July 22, 2026 20:13
@trask
trask requested a review from Copilot July 22, 2026 20:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-jms-nats-spring branch from 9830e5f to 1a2d882 Compare July 22, 2026 20:28
@trask
trask requested a review from Copilot July 22, 2026 20:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 64 out of 64 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants