Skip to content

Cover Kafka ecosystem messaging v1.43 telemetry#19271

Draft
trask wants to merge 5 commits into
open-telemetry:mainfrom
trask:messaging-v1-43-kafka-ecosystem
Draft

Cover Kafka ecosystem messaging v1.43 telemetry#19271
trask wants to merge 5 commits into
open-telemetry:mainfrom
trask:messaging-v1-43-kafka-ecosystem

Conversation

@trask

@trask trask commented Jul 19, 2026

Copy link
Copy Markdown
Member

Depends on #19270.

Dependency baseline: cd9360e14660d61ce7739ca4a41d9e4de17e6bd6.
Review only: cd9360e14660d61ce7739ca4a41d9e4de17e6bd6..cac11bfe6b0bc12e4c0df68046406280eb5f61ba.

Exactly one Kafka ecosystem commit. Stable topology assertions cover producer/process chains plus separate linked poll traces, including receive-telemetry opt-out and receive-enabled retry/failure paths.

Validated locally with the full check lifecycle for Kafka Streams, Reactor Kafka, Vert.x Kafka 3.6/4/5 testing, Spring Kafka, and testing-common, plus repository-wide spotlessCheck. Spring Kafka stable receive-enabled coverage includes single/batch success and retry/failure topology with exact error.type, parent, and link assertions.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Jul 19, 2026

Copy link
Copy Markdown

Pull request dashboard status

Status last refreshed: 2026-07-22 16:49:38 UTC.

  • Waiting on: Author
  • Next step: Move out of draft to request review.

This automated status or its linked feedback items may be incorrect. If something looks wrong, please report it with the result you expected.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Kafka messaging v1.43 preview coverage across downstream ecosystem integrations while retaining legacy assertions.

Changes:

  • Adds staged testV3Preview Gradle tasks.
  • Updates span names, kinds, attributes, and error assertions.
  • Covers Kafka Streams, Reactor Kafka, Spring Kafka, and Vert.x Kafka variants.

Reviewed changes

Copilot reviewed 67 out of 67 changed files in this pull request and generated no comments.

Show a summary per file
File Description
instrumentation/kafka/kafka-streams-0.11/javaagent/build.gradle.kts Adds v3-preview testing.
instrumentation/kafka/kafka-streams-0.11/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/kafkastreams/v0_11/KafkaStreamsDefaultTest.java Adds dual-semconv assertions.
instrumentation/reactor/reactor-kafka-1.0/javaagent/build.gradle.kts Adds v3-preview testing.
instrumentation/reactor/reactor-kafka-1.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/reactor/kafka/v1_0/AbstractReactorKafkaTest.java Updates messaging assertions.
instrumentation/spring/spring-kafka-2.7/javaagent/build.gradle.kts Adds v3-preview testing.
instrumentation/spring/spring-kafka-2.7/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/spring/kafka/v2_7/SpringKafkaTest.java Updates span and attribute coverage.
instrumentation/vertx/vertx-kafka-client-3.6/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/AbstractBatchRecordsNoReceiveTelemetryVertxKafkaTest.java Adapts batch no-receive assertions.
instrumentation/vertx/vertx-kafka-client-3.6/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/AbstractBatchRecordsVertxKafkaTest.java Adapts batch receive assertions.
instrumentation/vertx/vertx-kafka-client-3.6/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/AbstractSingleRecordNoReceiveTelemetryVertxKafkaTest.java Adapts single-record no-receive assertions.
instrumentation/vertx/vertx-kafka-client-3.6/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/AbstractSingleRecordVertxKafkaTest.java Adapts single-record receive assertions.
instrumentation/vertx/vertx-kafka-client-3.6/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/AbstractVertxKafkaTest.java Centralizes semconv-aware helpers.
instrumentation/vertx/vertx-kafka-client-3.6/vertx-kafka-client-3.6-testing/build.gradle.kts Adds v3-preview testing.
instrumentation/vertx/vertx-kafka-client-3.6/vertx-kafka-client-4-testing/build.gradle.kts Adds v3-preview testing.
instrumentation/vertx/vertx-kafka-client-3.6/vertx-kafka-client-5-testing/build.gradle.kts Adds v3-preview testing.

@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch from a37123c to 3fe6144 Compare July 21, 2026 04:45
@trask
trask requested a review from Copilot July 21, 2026 04:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 69 out of 69 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch 2 times, most recently from a54e285 to dc8b741 Compare July 21, 2026 05:37
@trask
trask requested a review from Copilot July 21, 2026 06:23

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 69 out of 69 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch from dc8b741 to 5feac07 Compare July 21, 2026 06:39
@trask
trask requested a review from Copilot July 21, 2026 06:50
@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch from 5feac07 to 220267d Compare July 21, 2026 06:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 69 out of 69 changed files in this pull request and generated 2 comments.

@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch from 220267d to 037ee2e Compare July 21, 2026 07:02
@trask
trask requested a review from Copilot July 21, 2026 07:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 69 out of 69 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch 2 times, most recently from 71bc588 to 9f84d9a Compare July 21, 2026 12:48
@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch from 9a6ab90 to f2748e7 Compare July 21, 2026 17:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 75 out of 75 changed files in this pull request and generated no new comments.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 75 out of 75 changed files in this pull request and generated 1 comment.

Comment thread instrumentation/spring/spring-kafka-2.7/javaagent/build.gradle.kts
@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch from f2748e7 to 7c9e191 Compare July 21, 2026 18:38
@trask
trask requested a review from Copilot July 21, 2026 18:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 75 out of 75 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch from 7c9e191 to d3a0603 Compare July 21, 2026 21:38
@trask
trask requested a review from Copilot July 21, 2026 21:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 75 out of 75 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

instrumentation/spring/spring-kafka-2.7/javaagent/build.gradle.kts:89

  • [Testing] This stable-preview task only runs the default test source set and explicitly enables receive telemetry, so the existing testNoReceiveTelemetry suite is still exercised only under legacy messaging semconv. That leaves Spring Kafka's stable receive-opt-out topology untested despite the PR's stated stable no-receive coverage. Add a preview task using the testNoReceiveTelemetry source set with receive telemetry disabled, and update that suite's legacy-only span/attribute assertions for v1.43.

@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch from d3a0603 to 6480017 Compare July 22, 2026 02:02
@trask
trask requested a review from Copilot July 22, 2026 02:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 77 out of 77 changed files in this pull request and generated no new comments.

@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch from 6480017 to 2ddfc00 Compare July 22, 2026 02:14
@trask
trask requested a review from Copilot July 22, 2026 02:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 77 out of 77 changed files in this pull request and generated 3 comments.

Comment thread instrumentation/spring/spring-kafka-2.7/javaagent/build.gradle.kts
@trask
trask force-pushed the messaging-v1-43-kafka-ecosystem branch from 2ddfc00 to cac11bf Compare July 22, 2026 02:45
@trask
trask requested a review from Copilot July 22, 2026 02:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 77 out of 77 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants