build(deps): ignore typescript major bumps in dependabot group - #484
Open
sspaink wants to merge 1 commit into
Open
build(deps): ignore typescript major bumps in dependabot group#484sspaink wants to merge 1 commit into
sspaink wants to merge 1 commit into
Conversation
typescript-eslint v8 declares a peer dependency of typescript ">=4.8.4 <6.1.0", so when dependabot bumped typescript to 7.x the grouped update failed `npm install` with ERESOLVE and both the build and lint jobs errored before running (#480). Since the npm group matches all packages, one incompatible major takes down the entire batch. Ignore typescript majors until typescript-eslint supports typescript 7. Signed-off-by: Sebastian Spaink <sebastianspaink@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#480 fails on both
buildandlintat thenpm install --include=devstep, before anything is compiled or linted:The grouped update bumped
typescriptfrom^6.0.3to^7.0.2, which no releasedtypescript-eslintsupports — 8.67.0 (latest at time of writing) still peers ontypescript >=4.8.4 <6.1.0. The v8 line only warns when TS 7 is detected (8.65.0); it doesn't support it.Because the npm group uses
patterns: ["*"], a single incompatible major blocks the whole batch of otherwise-safe patch/minor bumps.What
Ignore
semver-majorupdates fortypescriptso grouped dependency PRs stay mergeable. The comment notes to drop this once typescript-eslint supports TypeScript 7.Follow-up: #480 still needs
@dependabot recreate(or a@dependabot ignore typescript major versioncomment) to pick up the new config and drop the TS 7 bump.