deps+CLI: Begin using traits + make CLI optional. - #194
Open
philipaconrad wants to merge 1 commit into
Open
Conversation
This commit begins our usage of package traits for the library, and opens the door for future addition of external library use while still supporting a nearly dependency-free core profile for VM-only users. In this commit, we introduce a `CLI` trait, which we use to enable building the CLI target/product for Swift OPA. It also gates the swift-argument-parser library dependency, allowing VM only users to drop that dependency from their builds through traits. Signed-off-by: Philip Conrad <philip_conrad@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What code changed, and why?
This commit begins our usage of package traits for the library, and opens the door for future addition of external library use while still supporting a nearly dependency-free core profile for VM-only users.
In this commit, we introduce a
CLItrait, which we use to enable building the CLI target/product for Swift OPA. It also gates the swift-argument-parser library dependency, allowing VM only users to drop that dependency from their builds through traits.Resolves: #190
How to test
Related Resources