fix(runtime): Plumb custom headers through to spawned bundle loaders. - #47
Merged
philipaconrad merged 1 commit intoAug 1, 2026
Conversation
The RESTClientBundleLoader accepts custom headers in its initializers, but the Runtime didn't have any way to plumb custom headers through to the bundle loaders. We've now got the plumbing in place in the Runtime for custom headers on both DiscoveryConfigProvider and the RESTClientBundleLoader. Injected headers merge over `services.<name>.headers`, so they win on conflicts. Credential, ETag, and long-polling headers are still applied afterwards and will win over the other header sources. Signed-off-by: Philip Conrad <philip_conrad@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed, and why?
The
RESTClientBundleLoaderaccepts custom headers in its initializers, but the Runtime didn't have any way to plumb custom headers through to the bundle loaders.We've now got the plumbing in place in the Runtime for custom headers on both
DiscoveryConfigProviderand theRESTClientBundleLoader.Injected headers merge over
services.<name>.headers, so they win on conflicts. Credential, ETag, and long-polling headers are still applied afterwards and will win over the other header sources.How to test
Related Resources