Replace use of sort package with modern alternatives - #9013
Merged
Conversation
anderseknert
force-pushed
the
modernize-sorting
branch
from
August 13, 2026 15:55
798dd29 to
7bc0a9a
Compare
And a couple of other improvements to make use of more recent functions from the `slices`, `maps` and our own `util` packages. Added the forbidigo linter to make sure we're told about this should we forget it later. Signed-off-by: Anders Eknert <anders.eknert@apple.com>
anderseknert
force-pushed
the
modernize-sorting
branch
from
August 13, 2026 16:20
7bc0a9a to
f46b31b
Compare
sspaink
approved these changes
Aug 13, 2026
Benchmark Comparison (`88a03034abf2b267aae4d1b5d6690d03f814fa6d` vs `e7c18bbc721841a54fbf67613c48f6423aed05dc`)
This comment was automatically generated by the benchmarks workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And a couple of other improvements to make use of more recent functions from the
slices,mapsand our ownutilpackages.Added the forbidigo linter to make sure we're told about this should we forget it later.