Skip to content

Removed the deadcode, converted eTag and lastModifiedTime to volatile. #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sspaink merged 2 commits into from
Aug 13, 2026
Merged

Removed the deadcode, converted eTag and lastModifiedTime to volatile. #198

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a55664
Removed the deadcode, converted eTag and lastModifiedTime to volatile…
polachandu Aug 12, 2026
f8ee24a
Reverted the closing stream code because we are handling for multiple…
polachandu Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions opa-services/src/main/java/io/github/open_policy_agent/opa/plugins/BundleDownloader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,8 @@ public abstract class BundleDownloader {
protected String service;
protected String resource;
protected Config.PollingConfig polling;
protected String etag;
protected long lastModifiedTime = 0;
protected volatile String etag;
protected volatile long lastModifiedTime = 0;
protected long maxSizeBytes = Config.BundleConfig.DEFAULT_MAX_SIZE_BYTES;

// Fallback when no service config is available; matches the response_header_timeout_seconds
Expand Down Expand Up @@ -349,14 +349,10 @@ private CompletableFuture<Void> handleHttpDownload(URI uri) {

HttpRequest request = requestBuilder.build();

CompletableFuture<HttpResponse<InputStream>> exchange =
httpClient.sendAsync(request, HttpResponse.BodyHandlers.ofInputStream());
return exchange
return httpClient
.sendAsync(request, HttpResponse.BodyHandlers.ofInputStream())
.handle(
(response, throwable) -> {
if (throwable != null) {
exchange.cancel(true);
}
handleHttpResponse(response, throwable);
return null;
});
Expand Down
Loading