fix(builtins): register crypto and semver providers - #192
Merged
sspaink merged 1 commit intoAug 10, 2026
Merged
Conversation
The BuiltinProvider entries for opa-builtins-crypto and opa-builtins-semver were commented out in their META-INF/services files, so ServiceLoader never discovered them. Both modules were documented as supported in opa-builtins/README.md, but consumers could not actually call any of their builtins — `eval --capabilities-current` reported 113 builtins where it now reports 123. Registering these two needs no parity fixes: the compliance suite is green with their ten entries removed from known-missing-builtins.txt. The json, net and regex providers are still commented out. Registering all five at once fails 32 compliance cases (json 16, net 13, regex 3) and exhausts the default test heap, so those are left for follow-ups and the list header now records the split. Signed-off-by: Sebastian Spaink <sebastianspaink@gmail.com>
This was referenced Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
BuiltinProviderentries foropa-builtins-cryptoandopa-builtins-semverwere commented out in their
META-INF/servicesfiles, so ServiceLoader neverfound them. Both are documented as supported in
opa-builtins/README.md, butconsumers could not call any of their builtins —
eval --capabilities-currentreported 113 builtins and now reports 123.
Only the registration was broken; the implementations pass every compliance
fixture as soon as they are reachable, so this also removes their ten entries
from
known-missing-builtins.txt(74 → 64).json,netandregexare still commented out — registering all five at oncefails 32 compliance cases (json 16, net 13, regex 3), so those need follow-ups.
The list header now records that split.