-
Notifications
You must be signed in to change notification settings - Fork 22
Jitter StatusPlugin report interval between min/max delay #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sspaink
merged 3 commits into
open-policy-agent:main
from
arimu1:fix/80-status-plugin-jitter
Jul 22, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Defaulting
maxDelaySecondsto a non-null30makes the "unset max →2 * min" fallback inStatusPlugin.start()unreachable through config, and turns amin-only configuration into a validation error.Jackson only invokes a setter for keys physically present in the config, so an omitted
max_delay_secondsretains this30default rather than becomingnull. As a result:maxDelaySeconds = minDelaySeconds * 2instart()can only fire if a caller explicitly passesnull(as the test does) — never via normal YAML/JSON — contradicting the PR description's "ifmax_delay_secondsis unset, it now defaults to2 * min_delay_seconds."min_delay_seconds: 60(max omitted) keepsmax = 30, sovalidate()fails withmin_delay_seconds (60) cannot be greater than max_delay_seconds (30)at startup — even though they never configured a max.DecisionLogsConfigsidesteps this with split defaults (300/600), andReportingConfigusesnull/null. Consider defaultingmaxDelaySeconds(and probablyminDelaySeconds) tonullhere and applying the30default instart(), so the documentedmin-only fallback actually works.