Feature: add @oma-forge/shared for Forge API and OMA Core types#5
Merged
Conversation
Signed-off-by: Ibrahim Kazimov <74775400+ibrahimkzmv@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
@oma-forge/shared(packages/shared) as the single source of truth for Forge API types (RunSnapshot,ForgeEvent,ForgeTraceLine,DEFAULT_RUN_GOAL,parseForgeEvent) and re-exports of OMA Core types (TaskExecutionRecord,TeamRunResult, etc.). Server and web import from the shared package; duplicate types underapps/web/src/types/andapps/server/src/runs/{types,trace-types}.tsare removed. IntroducesForgeDashboardRunfor the DAG UI subset ofTeamRunResult.Why
Forge’s server <=> web contract was duplicated in two apps, which drifted from
@open-multi-agent/coreand made SSE/trace/run snapshots harder to keep in sync. A small shared workspace package keeps one typed contract and matches the v0.1 monorepo direction without pulling orchestration into the web bundle.Checklist
npm run lintpassesnpm testpassesDependencies: Adds workspace package
@oma-forge/shared, which depends on@open-multi-agent/corefor type re-exports. Web consumes shared for types andparseForgeEventonly, OMA execution remains on the server. Rootdev/build/lintbuild shared first.