[Feature] download command supports only downloaing config#216
Open
zhouzaida wants to merge 1 commit into
Open
[Feature] download command supports only downloaing config#216zhouzaida wants to merge 1 commit into
zhouzaida wants to merge 1 commit into
Conversation
|
Good development! I just have a small hint. The config file should be downloaded at first and after that the checkpoint file, because in general the config file is smaller than the checkpoint file. In addition we can write more elegant source code and avoid the indentation of the (if) condition: Original source code: for config in configs:
click.echo(f'processing {config}...')
# download checkpoint
if not ignore_checkpoint:
checkpoint_urls = model_info[config]['weight']
for checkpoint_url in checkpoint_urls.split(','):
# ...
checkpoints.append(filename)
# checkpoint config
config_paths = model_info[config]['config']
for config_path in config_paths.split(','):
# ...
return checkpointsChanged source code: for config in configs:
click.echo(f'processing {config}...')
# download config
config_paths = model_info[config]['config']
for config_path in config_paths.split(','):
# ...
if ignore_checkpoint:
continue
# download checkpoint
checkpoint_urls = model_info[config]['weight']
for checkpoint_url in checkpoint_urls.split(','):
# ...
checkpoints.append(filename)
return checkpoints@zhouzaida , what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist