Skip to content

[Feat] prompt the built version of mmcv-full#150

Open
ice-tong wants to merge 1 commit into
open-mmlab:mainfrom
ice-tong:yancong-feat-list_all_version
Open

[Feat] prompt the built version of mmcv-full#150
ice-tong wants to merge 1 commit into
open-mmlab:mainfrom
ice-tong:yancong-feat-list_all_version

Conversation

@ice-tong

@ice-tong ice-tong commented Jul 6, 2022

Copy link
Copy Markdown
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Get and prompt the built version of mmcv-full that satisfies the current environment. close #149

Modification

  • commands/install.py
  • utlis/utils.py
  • utils/__init__.py

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

image

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@ice-tong ice-tong requested a review from zhouzaida July 6, 2022 04:15
@codecov

codecov Bot commented Jul 6, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.46%. Comparing base (eb5c5c6) to head (9b369e7).
⚠️ Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
mim/commands/install.py 71.42% 2 Missing ⚠️
mim/utils/utils.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #150       +/-   ##
===========================================
+ Coverage   32.58%   54.46%   +21.88%     
===========================================
  Files          21       23        +2     
  Lines        1593     1568       -25     
  Branches      363      333       -30     
===========================================
+ Hits          519      854      +335     
+ Misses       1032      587      -445     
- Partials       42      127       +85     
Flag Coverage Δ
unittests 54.46% <82.35%> (+21.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mim install should prompt the supported built version of mmcv-full

1 participant