feat(vector-style-compiler): literal prop paths for selectors and attr()#121
Merged
Conversation
…tors and attr() Support prop| and env-prop| for flat GeoJSON keys such as stroke-width, fix selector tokenization for |js expressions containing brackets, and include selector paths in allowedProps for cache invalidation.
🦋 Changeset detectedLatest commit: 46dd109 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prop|andenv-prop|prefixes so selectors andattr()can read flat feature/env keys such asstroke-width(Simplestyle-style) instead of only nestedprops.stroke.widthpaths.|jsexpressions containing](for exampleprops['stroke-width']) compile correctly.allowedPropsand declaration-hash metadata so literal-key selectors participate in style-cache invalidation.Test plan
pnpm --filter @mapsight/vector-style-compiler testpnpm changeset status --since=origin/main