Resolve nation APK version metadata before writing apkversion#9643
Draft
Saby-Bishops wants to merge 1 commit into
Draft
Resolve nation APK version metadata before writing apkversion#9643Saby-Bishops wants to merge 1 commit into
Saby-Bishops wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
$tagto/usr/share/nginx/html/fs/apkversion, so the version needs to be resolved from nation-hosted metadata instead of relying on an undefined variable./fs/apkversion) and fall back to HTTP response headers so the server-side published version is captured when available./usr/share/nginx/html/fs/apkversionwhen metadata fetch or parsing fails.Description
resolve_apk_version()which first fetches"$nationUrl/fs/apkversion"and then falls back to parsing anx-apk-versionheader from aHEAD/GETresponse to"$downloadUrl".write_apk_version()which callsresolve_apk_version()and only writes the resolved non-empty value to/usr/share/nginx/html/fs/apkversion, leaving the existing file unchanged on failure.echo $tag > /usr/share/nginx/html/fs/apkversionoccurrences withwrite_apk_versionin both successful download/verify paths.Testing
sh -n docker/planet/nginx/upgrade_planetapk_fromnation.sh, which completed without errors.Codex Task