You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IDEAS.Templates.Examples.RadiatorHeating extends IDEAS.Templates.Examples.IdealRadiatorHeating and redeclares heating.
Unfortunately, in IDEAS.Templates.Examples.IdealRadiatorHeating, heating is redeclared without the replaceable keyword.
IDEAS.Templates.Examples.RadiatorHeating extends IDEAS.Templates.Examples.IdealRadiatorHeating and redeclares heating. Unfortunately, in IDEAS.Templates.Examples.IdealRadiatorHeating, heating is redeclared without the replaceable keyword.
This PR adds the missing keyword.
The model IDEAS.Templates.Examples.IdealRadiatorHeating extends from IDEAS.Templates.Examples.BaseClasses.SimpleHeatingsystem where the heating model is already declared replaceable:
replaceable IDEAS.Templates.Heating.BaseClasses.HysteresisHeating heating
constrainedby IDEAS.Templates.Interfaces.BaseClasses.HeatingSystem(
final nZones=nZones,
QNom={2000 for i in 1:nZones},
Q_design=structure.Q_design);
Only classes and components declared as replaceable can be redeclared with a new type, which
must have an interface compatible with the constraining interface of the original declaration, and
to allow further redeclarations one must use redeclarereplaceable.
And for whatever it is worth, we (Wolfram System Modeler) reject IDEAS.Templates.Examples.RadiatorHeating on that basis.
The reason will be displayed to describe this comment to others. Learn more.
@qlambert-pro Thank you for addressing the issue.
Based on the Modelica guidelines, I have updated the model IDEAS/Templates/Examples/IdealRadiatorHeating.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDEAS.Templates.Examples.RadiatorHeatingextendsIDEAS.Templates.Examples.IdealRadiatorHeatingand redeclaresheating.Unfortunately, in
IDEAS.Templates.Examples.IdealRadiatorHeating,heatingis redeclared without thereplaceablekeyword.This PR adds the missing keyword.