Skip to content

[#6315] add FAQItems option to component schemas#95

Merged
sergei-maertens merged 1 commit into
mainfrom
open-formulieren/6315-bottom-sheet-tooltip-attributes
Jun 12, 2026
Merged

[#6315] add FAQItems option to component schemas#95
sergei-maertens merged 1 commit into
mainfrom
open-formulieren/6315-bottom-sheet-tooltip-attributes

Conversation

@SonnyBA

@SonnyBA SonnyBA commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Closes the following bullet point in open-formulieren/open-forms#6315:

Update field component schemas to include newly configurable tool tip related fields

@SonnyBA SonnyBA force-pushed the open-formulieren/6315-bottom-sheet-tooltip-attributes branch from 353f712 to b061be6 Compare June 5, 2026 13:29
@SonnyBA SonnyBA marked this pull request as ready for review June 5, 2026 13:37
@SonnyBA SonnyBA self-assigned this Jun 5, 2026
Comment thread src/common.ts Outdated
@SonnyBA SonnyBA linked an issue Jun 8, 2026 that may be closed by this pull request
4 tasks
@SonnyBA SonnyBA force-pushed the open-formulieren/6315-bottom-sheet-tooltip-attributes branch from b061be6 to 51f8316 Compare June 8, 2026 13:47
@SonnyBA SonnyBA requested a review from viktorvanwijk June 8, 2026 14:13

@sergei-maertens sergei-maertens left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing a couple more things here:

  • Where are translations (NL, EN) going to be stored for the FAQItems? I'd suggest an openForms.translations key inside each FAQItem, for consistency. The backend will then have to extract the appropriate translation and assign it to the top level properties (similar to values from select/radio/selectboxes)
  • Your commit message and PR title still refer to "tooltip" now, please also update those.

Comment thread src/common.ts
@SonnyBA SonnyBA changed the title [#6315] add fieldTooltips option to component schemas [#6315] add FAQItems option to component schemas Jun 11, 2026
@SonnyBA SonnyBA force-pushed the open-formulieren/6315-bottom-sheet-tooltip-attributes branch from 51f8316 to 8243bef Compare June 11, 2026 12:12
@SonnyBA SonnyBA force-pushed the open-formulieren/6315-bottom-sheet-tooltip-attributes branch from 8243bef to 0ad2a05 Compare June 11, 2026 12:14
@sergei-maertens sergei-maertens merged commit da726f9 into main Jun 12, 2026
6 checks passed
@sergei-maertens sergei-maertens deleted the open-formulieren/6315-bottom-sheet-tooltip-attributes branch June 12, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for configurable bottom-sheet tool tips

2 participants