Skip to content

chore: resolve open dependabot security alerts#421

Open
jonathannorris wants to merge 6 commits into
mainfrom
chore/dependabot-alerts
Open

chore: resolve open dependabot security alerts#421
jonathannorris wants to merge 6 commits into
mainfrom
chore/dependabot-alerts

Conversation

@jonathannorris
Copy link
Copy Markdown
Member

@jonathannorris jonathannorris commented May 8, 2026

Summary

Adds and updates overrides in package.json to require at least the patched version of transitive dependencies (within the current major) for all open Dependabot security alerts. The alerts will auto-close once Dependabot re-scans against the resolved lockfile.

Dependabot Alerts Resolved

Alert Package Severity Fix
#128 serialize-javascript high Overridden to ^7.0.5 (RCE via RegExp/Date)
#171 serialize-javascript medium Overridden to ^7.0.5 (CPU exhaustion DoS)
#170 @tootallnate/once low Overridden to ^3.0.1
#159 fast-uri high Overridden to ^3.1.2 (path traversal)
#160 fast-uri high Overridden to ^3.1.2 (host confusion)
#161 @babel/plugin-transform-modules-systemjs high Overridden to ^7.29.4
#164 @opentelemetry/auto-instrumentations-node high Already on patched 0.75.0
#165 @opentelemetry/sdk-node high Already on patched 0.217.0
#168 protobufjs medium Override bumped to ^7.5.8 (lockfile resolves to 7.6.0)
#169 uuid medium New override to ^11.1.1 (buffer bounds check fix)
#172 qs medium Override bumped to ^6.15.2 (DoS via comma-format arrays)
#69, #70, #166 webpack-dev-server medium Overridden to ^5.2.4

Notes

  • All overrides use caret ranges to allow future patch/minor updates within the same major while still pinning at or above the patched version.
  • npm install requires --legacy-peer-deps due to a pre-existing @nestjs/schematics / prettier peer dependency conflict that is unrelated to this change.

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies, including upgrading serialize-javascript to version 7.0.5 and @tootallnate/once to version 3.0.1, while adding minimatch and removing randombytes. Feedback highlights that the serialize-javascript upgrade introduces a breaking requirement for Node.js 20.0.0, which may impact environments on older LTS versions. Additionally, it is recommended to use caret ranges instead of the >= operator in the dependency overrides to ensure stability and prevent unintended major version upgrades.

Comment thread package-lock.json
Comment thread package.json Outdated
- fast-uri 3.1.0 -> 3.1.2 (high, alerts #159 #160)
- @babel/plugin-transform-modules-systemjs 7.29.0 -> 7.29.4 (high, alert #161)

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
@jonathannorris jonathannorris marked this pull request as draft May 11, 2026 14:11
@jonathannorris jonathannorris marked this pull request as ready for review May 12, 2026 19:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds npm overrides to mitigate several Dependabot security alerts by forcing patched versions of vulnerable transitive dependencies.

Changes:

  • Added overrides for serialize-javascript, @tootallnate/once, fast-uri, and @babel/plugin-transform-modules-systemjs.
  • Kept existing test-exclude override (with minimatch) and extended the override list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread package.json Outdated
Comment thread package.json Outdated
- Bump @opentelemetry/sdk-node to ^0.217.0 (alert #165, high)
- Bump @opentelemetry/auto-instrumentations-node to ^0.75.0 (alert #164, high)
- Bump related @opentelemetry/* packages to OTel 2.x for compatibility
- Update scripts/tracing.js to use Resource API from OTel 2.x
- Add webpack-dev-server ^5.2.4 override (alerts #69, #70, #166, medium)

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
- Remove fast-uri override (ajv ^3.0.1 range already covers patched 3.1.2)
- Remove @babel/plugin-transform-modules-systemjs override (@babel/preset-env ^7.29.0 already covers patched 7.29.4)
- Downgrade @tootallnate/once override from ^3.0.1 to ^2.0.1 (http-proxy-agent requires major-2; patched 2.0.1 is in range)
- Remove protobufjs override; update @opentelemetry packages to 0.218.0 which drops the protobufjs dependency entirely

Signed-off-by: Jonathan Norris <jonathan.norris@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants