Skip to content

container: Update OffsetList#258

Open
Fuzzy2319 wants to merge 2 commits into
open-ead:masterfrom
Fuzzy2319:OffsetList
Open

container: Update OffsetList#258
Fuzzy2319 wants to merge 2 commits into
open-ead:masterfrom
Fuzzy2319:OffsetList

Conversation

@Fuzzy2319
Copy link
Copy Markdown
Contributor

@Fuzzy2319 Fuzzy2319 commented May 3, 2026

This PR add changes to OffsetList needed for KuriboHack in SMO.

  • an implicit cast operator for iterator/robustIterator to avoid writing &*iter
  • a -- operator for iterator they seems to iterate the list in reverse in KuriboHack::pushFrom

This change is Reviewable

Copy link
Copy Markdown
Contributor

@MonsterDruide1 MonsterDruide1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share a link to a WIP branch of where you plan to use these additional functions?
I encountered things that look like -- in the decompiled code, but were just a compiler optimization, because it recognized that iterating forwards and backwards had the same effect, and decided for some reason that backwards would be better - meaning that the -- operator wasn't needed. I suspect the same issue to be happening here, and would like to take a look at its usage.

@MonsterDruide1 made 1 comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved.

Copy link
Copy Markdown
Contributor Author

@Fuzzy2319 Fuzzy2319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants