Skip to content

all: fix declarations and types for symbols#65

Merged
MonsterDruide1 merged 4 commits into
open-ead:masterfrom
MonsterDruide1:fixes
May 11, 2026
Merged

all: fix declarations and types for symbols#65
MonsterDruide1 merged 4 commits into
open-ead:masterfrom
MonsterDruide1:fixes

Conversation

@MonsterDruide1
Copy link
Copy Markdown

@MonsterDruide1 MonsterDruide1 commented May 8, 2026

typedef results in the typedef-ed type appearing in the signature, instead of the name of the newly defined "type".
The easiest way to fix that is by creating full structs instead of only aliases, even if they only contain one member then.


This change is Reviewable

@MonsterDruide1 MonsterDruide1 self-assigned this May 8, 2026
Copy link
Copy Markdown

@german77 german77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@german77 reviewed 8 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on MonsterDruide1).

@MonsterDruide1
Copy link
Copy Markdown
Author

I should actually check whether the project compiles... we don't have a nice workflow for that here, compared to sead.

@german77 Please re-approve.

Copy link
Copy Markdown

@german77 german77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@german77 reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on MonsterDruide1).

@MonsterDruide1 MonsterDruide1 merged commit 08f9906 into open-ead:master May 11, 2026
2 checks passed
@MonsterDruide1 MonsterDruide1 deleted the fixes branch May 11, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants