refactor sync-to-s3.sh per directory#623
Merged
Merged
Conversation
RobHooper
commented
May 12, 2026
jpmckinney
reviewed
May 12, 2026
| AWS_ARGS=(--only-show-errors --delete) | ||
|
|
||
| set +e | ||
| $AWS_CLI s3 sync "$DIRECTORY" "s3://$S3_SYNC_BUCKET/$SAFENAME/" --only-show-errors --delete 2>&1 | grep -v "You did not provide the number of bytes specified by the Content-Length HTTP header" |
Member
There was a problem hiding this comment.
Do we not need this anymore?
2>&1 | grep -v "You did not provide the number of bytes specified by the Content-Length HTTP header"
Contributor
Author
There was a problem hiding this comment.
We may still want to ignore these alerts (files changing as the script runs).
I want to see how much the exclude functionality reduces these warnings first.
jpmckinney
reviewed
May 13, 2026
Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com>
jpmckinney
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies the sync-to-s3.sh to sync one directory rather than many, this allows us to add directory specific features (exclude paths #618) without the feature being applied to all paths.
The main complexity of backing up directories has been moved into Salt creating a cron for each sync path and setting features as required - this should prove more extendable in the future.
Closes #618
Connected tasks: