refactor(ocm): Streamline OCM component name and repository branding#464
Conversation
8R0WNI3
added
kind/refactor
|
Warning Review limit reached
More reviews will be available in 34 minutes and 45 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR systematically renames the project from "Delivery Dashboard" to "Open Delivery Gear UI" (odg-ui) and updates all related configuration, metadata, and documentation to reflect the new component identity and repository location. ChangesProject Rename: Delivery Dashboard → Open Delivery Gear UI
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
README.md (1)
8-10: ⚡ Quick winMinor inconsistency in project naming.
The description still refers to developing the
Delivery Dashboard, but the PR renames the project to "Open Delivery Gear UI". Consider updating this to align with the new naming:-This repository is used for developing the `Delivery Dashboard`, which is part of the Open -Delivery Gear. It is run against the `Delivery Service` as backing API and displays delivery +This repository is used for developing the `Open Delivery Gear UI`, which is part of the Open +Delivery Gear. It runs against the `Delivery Service` as backing API and displays delivery🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 8 - 10, Update the README text to use the new project name: replace occurrences of "Delivery Dashboard" with "Open Delivery Gear UI" (or the exact renamed title used in the PR) so the description line and any other references align with the new naming; ensure the phrase in the opening paragraph that currently reads "developing the `Delivery Dashboard`" is updated to "developing the `Open Delivery Gear UI`" (or the canonical project name string used elsewhere in the repo).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.ocm/base-component.yaml:
- Line 1: The repo declares the component as "name:
ocm.software/open-delivery-gear/ui" but CI, Helm chart and OCM references still
use "delivery-dashboard"; update .github/workflows/build.yaml to change the
workflow/helmchart config name and oci-repository from "delivery-dashboard" /
"odg/delivery-dashboard" to match "ocm.software/open-delivery-gear/ui" naming
convention, rename the Helm chart directory and Chart.yaml
(charts/delivery-dashboard/Chart.yaml) to use the new component name and update
its Chart.yaml "name" field, and replace all OCM resource keys
"ocm-resource:delivery-dashboard.repository" and
"ocm-resource:delivery-dashboard.tag" with the corresponding keys for the new
component name so all CI/helm/ocm refs consistently use
ocm.software/open-delivery-gear/ui.
In `@extension-definitions.yaml`:
- Line 5: The component name in extension-definitions.yaml under the "name:" key
("ocm.software/open-delivery-gear/odg-ui") does not match the component id in
.ocm/base-component.yaml ("ocm.software/open-delivery-gear/ui"); update the
string in extension-definitions.yaml to exactly match the base component id (or,
if the intended canonical id is "odg-ui", update .ocm/base-component.yaml
instead) so both files use the identical component name; locate the "name:"
entry in extension-definitions.yaml and make the replacement accordingly.
---
Nitpick comments:
In `@README.md`:
- Around line 8-10: Update the README text to use the new project name: replace
occurrences of "Delivery Dashboard" with "Open Delivery Gear UI" (or the exact
renamed title used in the PR) so the description line and any other references
align with the new naming; ensure the phrase in the opening paragraph that
currently reads "developing the `Delivery Dashboard`" is updated to "developing
the `Open Delivery Gear UI`" (or the canonical project name string used
elsewhere in the repo).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 93c64742-0486-4d8e-acc4-943c0323edc5
📒 Files selected for processing (7)
.env.development.env.production.ocm/base-component.yamlREADME.mdREUSE.tomlextension-definitions.yamlsrc/component/bom.js
| SPDX-PackageSupplier = "Christian Cwienk <christian.cwienk@sap.com>" | ||
| SPDX-PackageDownloadLocation = "https://github.com/open-component-model/delivery-dashboard" | ||
| SPDX-PackageName = "odg-ui" | ||
| SPDX-PackageSupplier = "ospo@sap.com" |
There was a problem hiding this comment.
@jakobmoellerdev can you help us setting the correct package supplier contact information here?
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
…ore` Signed-off-by: Jonas Brand (8R0WNI3) <j.brand@sap.com>
2 participants
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes open-component-model/open-delivery-gear#94
Special notes for your reviewer:
Release note: