:seedling: chore: upgrade to go 1.26 by tesshuflower · Pull Request #441 · open-cluster-management-io/api

tesshuflower · 2026-06-11T17:19:20Z

Upgrades Go version from 1.25 to 1.26.

Changes:

go.mod — go directive updated to 1.26.0
.github/workflows/go.yml — GO_VERSION updated to 1.26
Dockerfile.build — GO_VERSION updated to 1.26.0

Relates to: open-cluster-management-io/ocm#1555

Updates go.mod, Dockerfile.build, and GitHub Actions workflow to use Go 1.26. Relates to: open-cluster-management-io/ocm#1555 Signed-off-by: Tesshu Flower <tflower@redhat.com>

coderabbitai · 2026-06-11T17:19:32Z

Warning

Review limit reached

@tesshuflower, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 46 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 15bfe598-4598-4665-be4e-5005a3a18d39

📥 Commits

Reviewing files that changed from the base of the PR and between e022700 and f7cffe7.

📒 Files selected for processing (3)

.github/workflows/go.yml
Dockerfile.build
go.mod

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

dhaiducek

LGTM! Thanks @tesshuflower!

mikeshng · 2026-06-11T20:26:25Z

@coderabbitai review

coderabbitai · 2026-06-11T20:26:32Z

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copilot

Pull request overview

Upgrades this repository’s Go toolchain configuration to Go 1.26 across the module definition, CI workflow, and build container image.

Changes:

Bump go.mod go directive from 1.25.0 to 1.26.0.
Update GitHub Actions CI to use Go 1.26.
Update the build Dockerfile’s Go download version to 1.26.0.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
`go.mod`	Updates the module’s Go language/toolchain directive to 1.26.0.
`Dockerfile.build`	Updates the Go tarball version used in the build image to 1.26.0.
`.github/workflows/go.yml`	Updates CI to install and run against Go 1.26.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Address suggestions from Copilot review on PR open-cluster-management-io#441: - .github/workflows/go.yml: bump actions/checkout v3 -> v4 and actions/setup-go v3 -> v5 - Dockerfile.build: use curl -fsSLO instead of -LO to fail fast on HTTP errors (e.g. missing Go tarball returns 404 instead of downloading an error page) Signed-off-by: Tesshu Flower <tflower@redhat.com>

dhaiducek

I personally don't like a blanket commit that says "address suggestions". If you agree, could you make it more specific? In this case, probably separate it into two commits.

tesshuflower · 2026-06-11T21:44:05Z

I personally don't like a blanket commit that says "address suggestions". If you agree, could you make it more specific? In this case, probably separate it into two commits.

I guess I was trying to avoid too many commits so grouped them together? the commit details do explain exactly what the changes were - but you're right, it's not on the summary line.

I've updated to split into 2 commits so easier to see in the 1 ilner what the changes are.

- to fail fast on HTTP errors (e.g. missing Go tarball returns 404 instead of downloading an error page) Signed-off-by: Tesshu Flower <tflower@redhat.com>

- actions/checkout v3 -> v4 - actions/setup-go v3 -> v5 Signed-off-by: Tesshu Flower <tflower@redhat.com>

dhaiducek

Thanks! Right, the summary/title is what I was poking at--your descriptions in the body were definitely spot on. Though now I see PRs are Squash merged rather than rebased, so maybe it doesn't matter quite so much since it all gets dumped into the body anyway. 😬

qiujian16 · 2026-06-12T01:59:07Z

/approve

openshift-ci · 2026-06-12T01:59:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, qiujian16, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [qiujian16]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chore: upgrade to go 1.26

dc65661

Updates go.mod, Dockerfile.build, and GitHub Actions workflow to use Go 1.26. Relates to: open-cluster-management-io/ocm#1555 Signed-off-by: Tesshu Flower <tflower@redhat.com>

openshift-ci Bot requested review from jnpacker and qiujian16 June 11, 2026 17:19

tesshuflower changed the title ~~chore: upgrade to go 1.26~~ 🌱 chore: upgrade to go 1.26 Jun 11, 2026

dhaiducek approved these changes Jun 11, 2026

View reviewed changes

openshift-ci Bot assigned dhaiducek Jun 11, 2026

openshift-ci Bot added the lgtm label Jun 11, 2026

mikeshng requested a review from Copilot June 11, 2026 20:29

Copilot started reviewing on behalf of mikeshng June 11, 2026 20:29 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread Dockerfile.build Outdated

Comment thread .github/workflows/go.yml

openshift-ci Bot removed the lgtm label Jun 11, 2026

dhaiducek suggested changes Jun 11, 2026

View reviewed changes

tesshuflower added 2 commits June 11, 2026 17:46

Dockerfile.build: use curl -fsSLO instead of -LO

d8adc11

- to fail fast on HTTP errors (e.g. missing Go tarball returns 404 instead of downloading an error page) Signed-off-by: Tesshu Flower <tflower@redhat.com>

gh workflows go.yml: bump action versions

f7cffe7

- actions/checkout v3 -> v4 - actions/setup-go v3 -> v5 Signed-off-by: Tesshu Flower <tflower@redhat.com>

tesshuflower force-pushed the ocm-1555-golang-1.26 branch from 6c948de to f7cffe7 Compare June 11, 2026 21:49

dhaiducek approved these changes Jun 11, 2026

View reviewed changes

openshift-ci Bot added the lgtm label Jun 11, 2026

openshift-ci Bot added the approved label Jun 12, 2026

openshift-merge-bot Bot merged commit 1845fd8 into open-cluster-management-io:main Jun 12, 2026
9 checks passed

tesshuflower deleted the ocm-1555-golang-1.26 branch June 12, 2026 13:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🌱 chore: upgrade to go 1.26#441

🌱 chore: upgrade to go 1.26#441
openshift-merge-bot[bot] merged 3 commits into
open-cluster-management-io:mainfrom
tesshuflower:ocm-1555-golang-1.26

tesshuflower commented Jun 11, 2026

Uh oh!

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

Review limit reached

Uh oh!

dhaiducek left a comment

Uh oh!

mikeshng commented Jun 11, 2026

Uh oh!

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

dhaiducek left a comment

Uh oh!

tesshuflower commented Jun 11, 2026 •

edited

Loading

Uh oh!

dhaiducek left a comment

Uh oh!

qiujian16 commented Jun 12, 2026

Uh oh!

openshift-ci Bot commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

tesshuflower commented Jun 11, 2026

Uh oh!

coderabbitai Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

dhaiducek left a comment

Choose a reason for hiding this comment

Uh oh!

mikeshng commented Jun 11, 2026

Uh oh!

coderabbitai Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

dhaiducek left a comment

Choose a reason for hiding this comment

Uh oh!

tesshuflower commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhaiducek left a comment

Choose a reason for hiding this comment

Uh oh!

qiujian16 commented Jun 12, 2026

Uh oh!

openshift-ci Bot commented Jun 12, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

coderabbitai Bot commented Jun 11, 2026 •

edited

Loading

tesshuflower commented Jun 11, 2026 •

edited

Loading