✨ feat: add "random" placement prioritizer#437
Conversation
ref: https://redhat.atlassian.net/browse/ACM-19784 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dhaiducek The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughAdds a new Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
mikeshng
left a comment
There was a problem hiding this comment.
Would introducing randomness lead to unnecessary write operations and increased churn (ie excessive updates stored in etcd)?
I am assuming the list is no longer stabilized? Maybe the comment needs to explain that a bit futher.
Summary
Add "random" placement prioritizer to Placement API description.
Related issue(s)
Summary by CodeRabbit