Skip to content

fix: scope quote normalization to CLI input#585

Merged
gustavohenke merged 7 commits into
open-cli-tools:mainfrom
jeffrey-takuma:fix/normalize-cli-command-quotes
May 27, 2026
Merged

fix: scope quote normalization to CLI input#585
gustavohenke merged 7 commits into
open-cli-tools:mainfrom
jeffrey-takuma:fix/normalize-cli-command-quotes

Conversation

@jeffrey-takuma
Copy link
Copy Markdown
Contributor

Summary

Scope quote normalization to CLI input instead of the library API.

This moves the outer-quote normalization logic out of lib/concurrently.ts and into the CLI entrypoint, so well-formed shell commands keep their quotes when using the library API.

Closes #582

Changes

  • remove StripQuotes from lib/concurrently.ts
  • add bin/normalize-cli-command.ts for CLI-only command normalization
  • normalize CLI commands in bin/index.ts before calling concurrently()
  • add coverage for CLI normalization in bin/normalize-cli-command.spec.ts
  • add coverage for preserving quotes in the library API in lib/concurrently.spec.ts
  • add a thin CLI integration test in bin/index.spec.ts

Tests

  • pnpm test

@jeffrey-takuma
Copy link
Copy Markdown
Contributor Author

Opened this PR for #582.

The test jobs are passing on the PR. The only failing check seems to be the coverage upload step, which is currently returning a Coveralls 504 timeout.

@jeffrey-takuma jeffrey-takuma force-pushed the fix/normalize-cli-command-quotes branch from 0c04c54 to d0a082b Compare April 21, 2026 06:22
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 21, 2026

Coverage Status

coverage: 98.858%. first build — jeffrey-takuma:fix/normalize-cli-command-quotes into open-cli-tools:main

@jeffrey-takuma
Copy link
Copy Markdown
Contributor Author

@gustavohenke
I opened this PR to address #582, and it should be ready for review now. Could you take a look when you have a chance?

@gustavohenke gustavohenke self-requested a review May 27, 2026 05:51
Copy link
Copy Markdown
Member

@gustavohenke gustavohenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks reasonable!
I've pushed some further, small changes

@gustavohenke gustavohenke merged commit ae60bc4 into open-cli-tools:main May 27, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

StripQuotes regex incorrectly strips outer quotes from well-formed shell commands

3 participants