fix: validate Extra map keys don't collide with reserved cloud-init keys#43
Merged
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
Add validation in BuildCloudConfig to detect when opts.Extra contains keys that would overwrite reserved cloud-config keys (packages, write_files, runcmd, users, ssh_pwauth). Return error with ErrReservedKey to prevent silent configuration corruption. Changes: - Add ErrReservedKey error for collision detection - Validate Extra keys before maps.Copy merge - Add 7 test cases covering all reserved keys plus valid scenarios - Error message identifies the colliding key name Fixes #7 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
fix/validate-cloudinit-extra-key-collisions
branch
from
161556d to
49c52da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation in BuildCloudConfig to detect when opts.Extra contains keys that would overwrite reserved cloud-config keys (packages, write_files, runcmd, users, ssh_pwauth). Return error with ErrReservedKey to prevent silent configuration corruption.
Changes:
Fixes #7