feat: support storage and services in catalog workloads#197
Merged
Conversation
Extend CatalogManifest with Storage and Service fields. Add StorageDefinition, ServiceDefinition, and ServicePort types for YAML unmarshaling. Add validation in LoadCatalogEntry with error sentinels for name, size, serial, mount, port, and protocol constraints. Add buildCatalogServiceSpec and convertServicePorts helpers shared by GenericWorkload and GenericMultiWorkload. Update NewGenericWorkload to accept namespace parameter for service generation. Implement ExtraVolumes, ExtraDisks, DataVolumeTemplates, RequiresService, and ServiceSpec overrides on both GenericWorkload and GenericMultiWorkload. Inject diskSetupScript into cloud-init userdata when storage is declared. Refs: #196 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
…orkload Cover DataVolumeTemplates, ExtraDisks, ExtraVolumes, RequiresService, ServiceSpec, cloud-init disk setup script injection, runcmd ordering, selector-role routing, backward compatibility, and combined storage+service. Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workload.yamlmanifest schema with declarativestorageandservicesections so catalog workloads can provision DataVolumes, extra disks, and K8s Services without writing Go codeGenericWorkloadandGenericMultiWorkload— including cloud-init disk setup script injection with correct runcmd ordering (setup scripts run beforesystemctl daemon-reload)selector-roleon service definitions for multi-role workloads, routing to thevirtwork/rolelabelExample manifest
Test plan
Resolves #196