feat: add --params CLI flag for per-workload params#192
Merged
Conversation
Introduce ParseParams function that splits comma-separated "workload.key=value" strings into a per-workload param map. Add Ginkgo tests for happy paths and error cases. Include failing integration tests for --params flag (TDD red). Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
Add --params CLI flag to BindRunFlags accepting comma-separated workload.key=value pairs. LoadConfig resolves the raw string from CLI flag or VIRTWORK_PARAMS env var, parses it via ParseParams, and merges into WorkloadConfig.Params (CLI keys override YAML keys). Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--paramsCLI flag accepting comma-separatedworkload.key=valuepairs (e.g.,--params cpu.cpu-load-percent=50,cpu.cpu-method=matrixprod)VIRTWORK_PARAMSenvironment variable using the same format--paramsflag >VIRTWORK_PARAMSenv var > YAMLparams:block > schema defaultsDetails
Adds
ParseParams()to split the raw comma-separated string into amap[string]map[string]stringkeyed by workload name. Wires it intoLoadConfigviaresolveRawParams()(same pattern asresolveSSHKeys). Validation happens downstream in the orchestrator viaregistry.ValidateParams.Test plan
ParseParamsunit tests: single pair, multiple pairs same workload, multiple workloads, empty string, values containing=, whitespace trimmingParseParamserror tests: missing dot, empty workload name, missing=, empty key--paramsflag integration: flag parsing,VIRTWORK_PARAMSenv var, flag-over-env priority, CLI-overrides-YAML merge, CLI params for workloads absent from YAMLResolves #187