test(cmd/virtwork): increase test coverage from 11% to 85%#147
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
Add Ginkgo BDD tests covering all major cmd/virtwork code paths: - initAuditor: --no-audit flag, disabled config, valid/invalid db paths, --audit-db flag override - printSummary/printCleanupPreview: output formatting with various field combinations - runE: config error, invalid workload names, initAuditor error, cluster connection error, full dry-run path with single/multiple workloads and --vm-count - cleanupE: config error, initAuditor error, malformed kubeconfig, empty namespace, dry-run, --run-id filter, --yes skip prompt, user confirm/ decline prompt, --delete-namespace - newRootCmd/newRunCmd/newCleanupCmd: command structure and flag presence - PromptForConfirmation: EOF and reader error cases Add clusterConnect variable to enable injecting a fake client in cleanupE and runE tests without requiring a real cluster. Resolves #142 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
142-cmd-virtwork-test-coverage
branch
from
04c84fe to
a96ef0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Ginkgo BDD tests covering all major cmd/virtwork code paths:
Add clusterConnect variable to enable injecting a fake client in cleanupE and runE tests without requiring a real cluster.
Resolves #142