feat: validate workload names upfront and add VM creation concurrency limit#140
Merged
mrhillsman merged 3 commits intoMay 30, 2026
Merged
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrhillsman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
exe-prow-github-app
Bot
added
the
approved
…suggestions Validate all workload names against the registry before audit initialization so typos are caught early, including in --dry-run mode. Uses Levenshtein distance for "did you mean?" suggestions. Resolves #122 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
…eation Add errgroup.SetLimit to createVMs using a configurable concurrency cap (default 10) to prevent overwhelming API servers at scale. Resolves #125 Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
feat/122-125-workload-validation-concurrency-limit
branch
from
1b5db50 to
7297cfe
Compare
Signed-off-by: Melvin Hillsman <mhillsma@redhat.com>
mrhillsman
force-pushed
the
feat/122-125-workload-validation-concurrency-limit
branch
from
7297cfe to
5679eb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workload name validation:
ValidateWorkloadNames()now checks all--workloadsentries against the registry before audit initialization, so typos are caught early ? including in--dry-runmode. Invalid names get Levenshtein-based "did you mean?" suggestions (e.g.unknown workload(s): "cppu" (did you mean "cpu"?)).VM creation concurrency limit: Adds
--vm-concurrencyflag (default 10) that callserrgroup.SetLimit()increateVMs, capping the number of simultaneous API calls. Follows the existing pattern used bycreateSecrets.Resolves #122
Resolves #125