Skip to content

Refactor Frontend and Fix Backend Resource Leak #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
google-labs-jules wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor Frontend and Fix Backend Resource Leak #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions desktop/backend/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,15 @@ def setup_adb(self, port):
self.send_to_flutter({"type": "error", "message": f"ADB Error: {e}"})
return False

def cleanup_adb(self, port):
self.send_to_flutter({"type": "log", "message": "[*] Cleaning up ADB..."})
try:
subprocess.run(["adb", "forward", "--remove", f"tcp:{port}"],
check=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
except Exception as e:
# Don't send error to flutter, as it might not be connected
print(f"ADB cleanup error: {e}")

def _recv_exact(self, sock, n):
"""Receive exactly n bytes from socket"""
data = b''
Expand Down Expand Up @@ -346,6 +355,7 @@ def audio_stream_logic(self, device_name, port):
sock.close()
except: pass

self.cleanup_adb(port)
self.is_streaming = False
self.send_to_flutter({"type": "status", "payload": "stopped"})
self.send_to_flutter({"type": "volume", "value": 0.0})
Expand Down
Loading